From: Jeff King <peff@peff.net> To: John Keeping <john@keeping.me.uk> Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org Subject: Re: [PATCH] git-config(1): clarify precedence of multiple values Date: Sun, 7 Jul 2013 15:55:18 -0400 Message-ID: <20130707195518.GB20700@sigill.intra.peff.net> (raw) In-Reply-To: <20130707194956.GU9161@serenity.lan> On Sun, Jul 07, 2013 at 08:49:56PM +0100, John Keeping wrote: > In order to clarify which value is used when there are multiple values > defined for a key, re-order the list of file locations so that it runs > from least specific to most specific. Then add a paragraph which simply > says that the last value will be used. Makes sense. > file is not available or readable, 'git config' will exit with a non-zero > error code. However, in neither case will an error message be issued. > > +The files are read in the order given above, with last value found taking > +precedence over values read earlier. When multiple values are taken then all > +values of a key from all files will be used. What order do the values come in --get-all? If you read carefully, I think it is implied by the "files are read in order given above", but it took me a minute to think about it. Maybe add at the end: ...values of a key from all files will be shown, in the order the files are processed (least specific to most specific). Or something (I do not like "least specific" because we have not introduced that term earlier, but I can't think of another succinct way to say it). But even without that, the patch is certainly an improvement. -Peff
prev parent reply other threads:[~2013-07-07 19:55 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-03 18:27 [PATCH] git-config: update doc for --get with " John Keeping 2013-07-03 18:32 ` Jeff King 2013-07-03 18:47 ` Junio C Hamano 2013-07-07 9:50 ` John Keeping 2013-07-07 17:31 ` Junio C Hamano 2013-07-07 19:49 ` [PATCH] git-config(1): clarify precedence of " John Keeping 2013-07-07 19:55 ` Jeff King [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130707195518.GB20700@sigill.intra.peff.net \ --to=peff@peff.net \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=john@keeping.me.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git