From: Jonathan Nieder <jrnieder@gmail.com>
To: David Rothenberger <daveroth@acm.org>
Cc: git@vger.kernel.org, users@subversion.apache.org,
"Kyle J. McKay" <mackyle@gmail.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 0/2] allow git-svn fetching to work using serf
Date: Sun, 7 Jul 2013 10:53:16 -0700 [thread overview]
Message-ID: <20130707175316.GB9975@google.com> (raw)
In-Reply-To: <51D8E40F.2020008@acm.org>
(cc-ing users@ as requested by danielsh)
David Rothenberger wrote:
> On 7/6/2013 5:28 PM, Jonathan Nieder wrote:
>> Is there a simple explanation of why violating the depth-first
>> constraint would lead to multiple blob (i.e., file, not directory)
>> deltas being opened in a row without an intervening close?
>
> I believe serf is doing the following for a number of files in parallel:
> 1. open_file
> 2. apply_textdelta
> 3. change_file_prop, change_file_prop, ...
> 4. close_file
Ah, that makes more sense. It is not about traversal order but about
processing multiple non-directory files in parallel, and step (3)
potentially involving a large number of property changes means that it
can make sense not to take a lock.
Perhaps the reference documentation could warn about this?
On the git-svn side, it looks like we have enough information to make
a more complete commit message or in-code comment so the reason for
multiple git_blob tempfiles is not forgotten. Thanks for your patient
explanations.
Jonathan
prev parent reply other threads:[~2013-07-07 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 3:41 [PATCH 0/2] allow git-svn fetching to work using serf Kyle McKay
2013-07-06 7:17 ` David Rothenberger
2013-07-07 0:28 ` Jonathan Nieder
2013-07-07 1:24 ` Kyle McKay
2013-07-07 1:37 ` Jonathan Nieder
2013-07-07 2:46 ` Kyle McKay
2013-07-07 17:40 ` Jonathan Nieder
2013-07-07 3:44 ` David Rothenberger
2013-07-07 17:53 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707175316.GB9975@google.com \
--to=jrnieder@gmail.com \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=mackyle@gmail.com \
--cc=normalperson@yhbt.net \
--cc=users@subversion.apache.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).