* [PATCH] diffcore-pickaxe: simplify has_changes and contains
@ 2013-07-06 13:53 René Scharfe
2013-07-07 4:03 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2013-07-06 13:53 UTC (permalink / raw)
To: git; +Cc: Jeff King, Junio C Hamano
Halve the number of callsites of contains() to two using temporary
variables, simplifying the code. While at it, get rid of the
diff_options parameter, which became unused with 8fa4b09f.
Signed-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
---
diffcore-pickaxe.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index c97ac9b..401eb72 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -131,8 +131,7 @@ static void diffcore_pickaxe_grep(struct diff_options *o)
return;
}
-static unsigned int contains(mmfile_t *mf, struct diff_options *o,
- regex_t *regexp, kwset_t kws)
+static unsigned int contains(mmfile_t *mf, regex_t *regexp, kwset_t kws)
{
unsigned int cnt;
unsigned long sz;
@@ -176,11 +175,9 @@ static int has_changes(mmfile_t *one, mmfile_t *two,
struct diff_options *o,
regex_t *regexp, kwset_t kws)
{
- if (!one)
- return contains(two, o, regexp, kws) != 0;
- if (!two)
- return contains(one, o, regexp, kws) != 0;
- return contains(one, o, regexp, kws) != contains(two, o, regexp, kws);
+ unsigned int one_contains = one ? contains(one, regexp, kws) : 0;
+ unsigned int two_contains = two ? contains(two, regexp, kws) : 0;
+ return one_contains != two_contains;
}
static int pickaxe_match(struct diff_filepair *p, struct diff_options *o,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains
2013-07-06 13:53 [PATCH] diffcore-pickaxe: simplify has_changes and contains René Scharfe
@ 2013-07-07 4:03 ` Jeff King
2013-07-07 17:25 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2013-07-07 4:03 UTC (permalink / raw)
To: René Scharfe; +Cc: git, Junio C Hamano
On Sat, Jul 06, 2013 at 03:53:27PM +0200, René Scharfe wrote:
> Halve the number of callsites of contains() to two using temporary
> variables, simplifying the code. While at it, get rid of the
> diff_options parameter, which became unused with 8fa4b09f.
There is a slight change in behavior, too:
> - if (!one)
> - return contains(two, o, regexp, kws) != 0;
> - if (!two)
> - return contains(one, o, regexp, kws) != 0;
> - return contains(one, o, regexp, kws) != contains(two, o, regexp, kws);
> + unsigned int one_contains = one ? contains(one, regexp, kws) : 0;
> + unsigned int two_contains = two ? contains(two, regexp, kws) : 0;
> + return one_contains != two_contains;
Before, if (!one && !two) we would call contains(two, ...), and now we
will simply assume it is zero. Which I think is an improvement, as we
would have segfaulted before. I don't think it is a bug in the current
code (we would not ever feed the function two NULLs), but it is nice to
be more defensive.
Acked-by: Jeff King <peff@peff.net>
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains
2013-07-07 4:03 ` Jeff King
@ 2013-07-07 17:25 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2013-07-07 17:25 UTC (permalink / raw)
To: Jeff King; +Cc: René Scharfe, git
Jeff King <peff@peff.net> writes:
> Before, if (!one && !two) we would call contains(two, ...), and now we
> will simply assume it is zero. Which I think is an improvement, as we
> would have segfaulted before. I don't think it is a bug in the current
> code (we would not ever feed the function two NULLs), but it is nice to
> be more defensive.
>
> Acked-by: Jeff King <peff@peff.net>
Thanks, both.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-07 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-06 13:53 [PATCH] diffcore-pickaxe: simplify has_changes and contains René Scharfe
2013-07-07 4:03 ` Jeff King
2013-07-07 17:25 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).