From: John Keeping <john@keeping.me.uk>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Lukas Fleischer <git@cryptocrack.de>,
Alois Mahdal <Alois.Mahdal.1-ndmail@zxcvb.cz>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: --follow is ignored when used with --reverse
Date: Tue, 2 Jul 2013 11:41:19 +0100 [thread overview]
Message-ID: <20130702104119.GB9161@serenity.lan> (raw)
In-Reply-To: <87vc4t9tn5.fsf@linux-k42r.v.cablecom.net>
On Tue, Jul 02, 2013 at 11:51:42AM +0200, Thomas Rast wrote:
> Lukas Fleischer <git@cryptocrack.de> writes:
>
> > On Tue, Jul 02, 2013 at 10:19:36AM +0100, John Keeping wrote:
> [...]
> >> $ git log --oneline --follow builtin/clone.c | wc -l
> >> 125
> >> $ git log --oneline --follow --reverse builtin/clone.c | wc -l
> >> 3
> >
> > I just wanted to point out that it works fine when specifying the *original*
> > file name (which kind of makes sense given that everything is done in reverse
> > order):
> [...]
> > However, that also doesn't seem to work for builtin/clone.c:
> >
> > $ git log --oneline --follow --reverse -- builtin-clone.c | wc -l
> > 65
>
> I'm pretty sure that is simply because --follow iis a horrible hack,
> known to be broken in many ways. I have it on my longer-term todo list
> to unify it with -L -M, which already does the Right Thing (more
> generally, not in the --reverse interaction, which it never occurred to
> me I should check).
Interesting... this tells me that --reverse doesn't work the way I
thought it did (although without any real evidence). Given how
--reverse interacts with other options (like --max-count), I assumed it
would generate the commit list first and then simply reverse it before
display but it seems that this isn't what happens with --follow.
I guess that makes sense to avoid calculating the diff twice but I
suspect we have to pay that price to get correct output.
next prev parent reply other threads:[~2013-07-02 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 23:23 --follow is ignored when used with --reverse Alois Mahdal
2013-07-02 8:56 ` alois.mahdal.1-ndmail
2013-07-02 9:12 ` Ramkumar Ramachandra
2013-07-02 9:19 ` John Keeping
2013-07-02 9:38 ` Lukas Fleischer
2013-07-02 9:51 ` Thomas Rast
2013-07-02 10:41 ` John Keeping [this message]
2013-07-02 19:11 ` Junio C Hamano
2013-07-02 11:20 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702104119.GB9161@serenity.lan \
--to=john@keeping.me.uk \
--cc=Alois.Mahdal.1-ndmail@zxcvb.cz \
--cc=git@cryptocrack.de \
--cc=git@vger.kernel.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).