From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] completion: add completer for rev-parse
Date: Sun, 30 Jun 2013 13:14:36 +0200 [thread overview]
Message-ID: <20130630111436.GB2294@goldbirke> (raw)
In-Reply-To: <1372429088-385-4-git-send-email-artagnon@gmail.com>
On Fri, Jun 28, 2013 at 07:48:07PM +0530, Ramkumar Ramachandra wrote:
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
> contrib/completion/git-completion.bash | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 278018f..f2959a7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2247,6 +2247,20 @@ _git_reset ()
> __gitcomp_nl "$(__git_refs)"
> }
>
> +_git_rev_parse ()
> +{
> + case "$cur" in
> + --*)
> + __gitcomp "
> + --short --show-toplevel --is-inside-work-tree
> + --symbolic-full-name --verify
> + "
In the completion script we support porcelain commands. I'm not sure
about 'git rev-parse', but I think it's more plumbing than porcelain.
However, I think the same about 'git ls-tree' and 'git reflog', too,
yet we have support for them in the completion script.
Either way, why these five options? 'git rev-parse' has a lot more
options than that.
> + return
> + ;;
> + esac
> + __gitcomp_nl "$(__git_refs)"
> +}
> +
> _git_revert ()
> {
> case "$cur" in
> --
> 1.8.3.1.585.g9832cb9
>
next prev parent reply other threads:[~2013-06-30 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 14:18 [PATCH 0/4] Batch completion improvements Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 1/4] completion: complete rebase --edit-todo Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 2/4] completion: add completer for status Ramkumar Ramachandra
2013-06-30 11:19 ` SZEDER Gábor
2013-06-30 11:24 ` Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 3/4] completion: add completer for rev-parse Ramkumar Ramachandra
2013-06-30 11:14 ` SZEDER Gábor [this message]
2013-06-30 11:17 ` Ramkumar Ramachandra
2013-06-30 19:03 ` Junio C Hamano
2013-07-03 10:30 ` Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 4/4] completion: prefer to use local git-completion.bash Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130630111436.GB2294@goldbirke \
--to=szeder@ira.uka.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).