git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Junio C Hamano <gitster@pobox.com>,
	Johan Herland <johan@herland.net>,
	Thomas Rast <trast@inf.ethz.ch>,
	git@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fix a race condition when reading loose refs
Date: Wed, 19 Jun 2013 12:01:51 -0400	[thread overview]
Message-ID: <20130619160150.GA19139@sigill.intra.peff.net> (raw)
In-Reply-To: <1371623788-7227-1-git-send-email-mhagger@alum.mit.edu>

On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:

> I took Peff's suggestion to use gotos rather than an infinite loop in
> the last patch, which means that there is no need for the old patch
> 03/04.

Thanks, this version looks good to me.

I'm sure the Pascal programmers of the world collectively sighed in
disgust at a code review requesting a for loop turn into a goto, but I
think it is more readable than the first version. :)

-Peff

  parent reply	other threads:[~2013-06-19 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  6:36 [PATCH v2 0/3] Fix a race condition when reading loose refs Michael Haggerty
2013-06-19  6:36 ` [PATCH v2 1/3] resolve_ref_unsafe(): extract function handle_missing_loose_ref() Michael Haggerty
2013-06-19  6:36 ` [PATCH v2 2/3] resolve_ref_unsafe(): handle the case of an SHA-1 within loop Michael Haggerty
2013-06-19  6:36 ` [PATCH v2 3/3] resolve_ref_unsafe(): close race condition reading loose refs Michael Haggerty
2013-06-19 16:01 ` Jeff King [this message]
2013-06-19 17:24   ` [PATCH v2 0/3] Fix a race condition when " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619160150.GA19139@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johan@herland.net \
    --cc=mhagger@alum.mit.edu \
    --cc=trast@inf.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).