From: "Michael S. Tsirkin" <mst@redhat.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org
Subject: Re: send-email adds redundant From: lines to message body
Date: Tue, 18 Jun 2013 14:42:07 +0300 [thread overview]
Message-ID: <20130618114207.GD26857@redhat.com> (raw)
In-Reply-To: <20130618110904.GA20052@goldbirke>
On Tue, Jun 18, 2013 at 01:09:04PM +0200, SZEDER Gábor wrote:
> Hi,
>
> 'git send-email' recently started to add redundant From: lines to my
> messages, see e.g.
>
> http://article.gmane.org/gmane.comp.version-control.git/228132
Can you please show what do commits point to?
E.g. push to some public tree?
> Bisect points to:
>
> commit da18759e86bb1a7ee718c79a0c6cb15fbcbdf3c2
> Author: Michael S. Tsirkin <mst@redhat.com>
> Date: 2013-06-05 21:11:00 +0300
>
> send-email: make --suppress-cc=self sanitize input
>
> --suppress-cc=self fails to filter sender address in many cases where it
> needs to be sanitized in some way, for example quoted:
> "A U. Thor" <author@example.com>
> To fix, make send-email sanitize both sender and the address it is
> compared against.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> The exact commands I run were:
>
> git format-patch --cover-letter --subject-prefix='PATCH v2' 2847cae835fa70f00e6e2286fbfa5595cb2247d0..bash-prompt-speedup
> vim 0000-cover-letter.patch
> git send-email --to=git@vger.kernel.org 00*
>
> i.e. no '--suppress-cc=self' option at all. Values of related config
> variables are:
>
> git config --get-regexp '(sendemail|user)\..*'
> sendemail.smtpserver /usr/local/bin/putmail
> sendemail.confirm auto
> user.name SZEDER Gábor
> user.email szeder@ira.uka.de
>
> The 'á' in my first name is apparently significant: creating a commit
> and sending it as a patch with that accent removed doesn't trigger a
> redundant From: line.
>
>
> Thanks,
> Gábor
next prev parent reply other threads:[~2013-06-18 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 11:09 send-email adds redundant From: lines to message body SZEDER Gábor
2013-06-18 11:42 ` Michael S. Tsirkin [this message]
2013-06-18 11:48 ` SZEDER Gábor
2013-06-18 12:36 ` Michael S. Tsirkin
2013-06-18 12:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618114207.GD26857@redhat.com \
--to=mst@redhat.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).