From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] git.txt: document GIT_TRACE_PACKET
Date: Sun, 9 Jun 2013 01:55:10 -0400 [thread overview]
Message-ID: <20130609055509.GA17617@sigill.intra.peff.net> (raw)
In-Reply-To: <1370757210-2994-1-git-send-email-pclouds@gmail.com>
On Sun, Jun 09, 2013 at 12:53:30PM +0700, Nguyen Thai Ngoc Duy wrote:
> "This can help with debugging object negotiation or other protocol
> issues."
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> >> +'GIT_TRACE_PACKET'::
> >> + If this variable is set, it shows a trace of all packets
> >> + coming in or out of a given program. This can help with
> >> + debugging object negotiation or other protocol issues.
> >
> > This is not quite true. It stops showing packets after it sees a packet
> > starting with "PACK" (optionally with a sideband prefix). So you would
> > miss, for example, a sideband error that came after the pack had
> > started. So it is really only useful for looking at the ref and object
> > negotiation phases.
>
> I blindly copied the first paragraph from bbc30f9 (add packet tracing
> debug code - 2011-02-24) and missed the "PACK" bit in the second one.
> How about this?
Hmm, what do you know, I sort-of documented it already. I think I just
never guessed that anybody but people reading "git log" would actually
need to use TRACE_PACKET. :)
Thanks, the patch looks fine to me.
-Peff
next prev parent reply other threads:[~2013-06-09 5:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 5:22 [PATCH 1/2] core: use env variable instead of config var to turn on logging pack access Nguyễn Thái Ngọc Duy
2013-06-09 5:22 ` [PATCH 2/2] git.txt: document GIT_TRACE_PACKET Nguyễn Thái Ngọc Duy
2013-06-09 5:36 ` Jeff King
2013-06-09 5:53 ` Nguyễn Thái Ngọc Duy
2013-06-09 5:55 ` Jeff King [this message]
2013-06-09 23:16 ` Junio C Hamano
2013-06-09 7:20 ` Eric Sunshine
2013-06-09 7:17 ` [PATCH 1/2] core: use env variable instead of config var to turn on logging pack access Eric Sunshine
2013-06-09 7:18 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2013-05-30 13:51 Nguyễn Thái Ngọc Duy
2013-05-30 13:51 ` [PATCH 2/2] git.txt: document GIT_TRACE_PACKET Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609055509.GA17617@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).