From: "Michael S. Tsirkin" <mst@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4 0/7] git send-email suppress-cc=self fixes
Date: Wed, 5 Jun 2013 23:14:23 +0300 [thread overview]
Message-ID: <20130605201423.GB31143@redhat.com> (raw)
In-Reply-To: <7v8v2o1ho7.fsf@alter.siamese.dyndns.org>
On Wed, Jun 05, 2013 at 12:28:08PM -0700, Junio C Hamano wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > This includes bugfixes related to handling of --suppress-cc=self
> > flag. Tests are also included.
> >
> > Changes from v3:
> > - v3 submission was missing one patch (1/7). Re-add it.
> > Changes from v2:
> > - add a new test, split patches differently add code comments
> > to address comments by Junio
> > - rename example addresses in tests from redhat.com to example.com
> > Changes from v1:
> > - tweak coding style in tests to address comments by Junio
>
> Nice. This round cleanly applies and the interdiff since v2 looked
> sensible.
>
> Will replace and merge to 'next' shortly.
>
> Thanks.
Wellcome.
With respect to this, and a bit off-topic, what's
the best way to revise patch series?
What I did, given series in patchvN-1/:
rm -fr patchvN #blow away old directory if there
# otherwise I get two copies of patches if I renamed any
git branch|fgrep '*'
# Figure out on which branch I am, manually specify the correct upstream I'm tracking,
# otherwise I get a ton of unrelated patches.
git format-patch --cover --subject-prefix='PATCH vN' -o patchvN origin/master..
vi patchvN/0000* patchvN-1/0000*
#manually copy subject, Cc list and text from vN-1 to vN cover letter,
#leave stats intact.
git log origin/master.. |grep -e Cc: -e Reviewed -e Acked
# manually Look who reviewed/acked all patches in previous versions -
# if so copy them on cover letter too.
git send-email --cc=junio patchvN/*
lots of manual steps here.
Any ways to automate?
> >
> > Michael S. Tsirkin (7):
> > t/send-email.sh: add test for suppress-cc=self
> > send-email: fix suppress-cc=self on cccmd
> > t/send-email: test suppress-cc=self on cccmd
> > send-email: make --suppress-cc=self sanitize input
> > t/send-email: add test with quoted sender
> > t/send-email: test suppress-cc=self with non-ascii
> > test-send-email: test for pre-sanitized self name
> >
> > git-send-email.perl | 23 ++++++++++------
> > t/t9001-send-email.sh | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 90 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2013-06-05 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 18:10 [PATCH v4 0/7] git send-email suppress-cc=self fixes Michael S. Tsirkin
2013-06-05 19:28 ` Junio C Hamano
2013-06-05 20:14 ` Michael S. Tsirkin [this message]
2013-06-09 23:25 ` Junio C Hamano
2013-06-10 6:53 ` Michael S. Tsirkin
2013-06-10 7:29 ` John Keeping
2013-06-10 8:59 ` Michael S. Tsirkin
2013-06-10 7:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605201423.GB31143@redhat.com \
--to=mst@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).