From: "Michael S. Tsirkin" <mst@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/6] git send-email suppress-cc=self fixes
Date: Wed, 5 Jun 2013 00:49:22 +0300 [thread overview]
Message-ID: <20130604214921.GA30400@redhat.com> (raw)
In-Reply-To: <7v4ndd93ks.fsf@alter.siamese.dyndns.org>
On Tue, Jun 04, 2013 at 10:40:51AM -0700, Junio C Hamano wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > This includes bugfixes related to handling of --suppress-cc=self
> > flag. Tests are also included.
>
> Hmph, flipped the patches without test-applying first?
No, I generated the patches with git format-patch,
then processed with git send-email.
> 2/6 adds two lines to test_suppress_self_quoted helper function, but
> that is introduced only at 4/6.
I don't see it
All I see in 2/6 is this:
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index e1a7f3e..f81e5f5 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -204,13 +204,15 @@ test_suppress_self_unquoted () {
unquoted-$3
+ cccmd--$1 <$2>
+
Cc: $1 <$2>
Signed-off-by: $1 <$2>
EOF
}
test_expect_success $PREREQ 'self name is suppressed' "
- test_suppress_self_unquoted 'A U Thor' 'author@redhat.com' \
+ test_suppress_self_unquoted 'A U Thor' 'author@example.com' \
'self_name_suppressed'
"
where's test_suppress_self_quoted here?
> >
> > Changes from v2:
> > - add a new test, split patches differently add code comments
> > to address comments by Junio
> > - rename example addresses in tests from redhat.com to example.com
> > Changes from v1:
> > - tweak coding style in tests to address comments by Junio
> >
> >
> > Michael S. Tsirkin (6):
> > send-email: fix suppress-cc=self on cccmd
> > t/send-email: test suppress-cc=self on cccmd
> > send-email: make --suppress-cc=self sanitize input
> > t/send-email: add test with quoted sender
> > t/send-email: test suppress-cc=self with non-ascii
> > test-send-email: test for pre-sanitized self name
> >
> > git-send-email.perl | 23 +++++++++++++++--------
> > t/t9001-send-email.sh | 34 +++++++++++++++++++++++++++++++++-
> > 2 files changed, 48 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2013-06-04 21:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 7:55 [PATCH v3 0/6] git send-email suppress-cc=self fixes Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 1/6] send-email: fix suppress-cc=self on cccmd Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 2/6] t/send-email: test " Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 3/6] send-email: make --suppress-cc=self sanitize input Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 4/6] t/send-email: add test with quoted sender Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 5/6] t/send-email: test suppress-cc=self with non-ascii Michael S. Tsirkin
2013-06-04 7:56 ` [PATCH v3 6/6] test-send-email: test for pre-sanitized self name Michael S. Tsirkin
2013-06-04 17:40 ` [PATCH v3 0/6] git send-email suppress-cc=self fixes Junio C Hamano
2013-06-04 21:49 ` Michael S. Tsirkin [this message]
2013-06-04 22:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604214921.GA30400@redhat.com \
--to=mst@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).