From: Ian Kumlien <pomac@vapor.com>
To: Jeff King <peff@peff.net>
Cc: Martin Fick <mfick@codeaurora.org>, git@vger.kernel.org
Subject: Re: git hangs on pthread_join
Date: Wed, 29 May 2013 10:29:03 +0200 [thread overview]
Message-ID: <20130529082903.GC22308@pomac.netswarm.net> (raw)
In-Reply-To: <20130528175108.GA21210@sigill.intra.peff.net>
On Tue, May 28, 2013 at 01:51:09PM -0400, Jeff King wrote:
> On Thu, May 23, 2013 at 03:01:43PM +0200, Ian Kumlien wrote:
>
> > git 1.8.2.1 is started by xinetd
> > [...]
> > I have found "git receive-pack"s that has been running for days/weeks
> > without terminating....
> >
> > Attaching gdb and doing a trace results in:
> > #0 0x0000003261207b35 in pthread_join () from /lib64/libpthread.so.0
> > #1 0x00000000004ce58b in finish_async ()
> > #2 0x000000000045744b in cmd_receive_pack ()
> > #3 0x0000000000404851 in handle_internal_command ()
> > #4 0x0000000000404c9d in main ()
>
> I recently fixed a deadlock that could happen in receive-pack when
> clients hung up before sending a valid pack header. The fix is commit
> 49ecfa1, and it's in git v1.8.2.2.
With dodgy connections this could easily happen =)
Really nice catch!
> The stack trace for the deadlock fixed by 49ecfa1 would have
> unpack_with_sideband between #1 and #2 above, but it is entirely
> possible that it is simply inlined in your build of git, depending on
> the -O level of your build (it is a static function that is only called
> from one place). So it seems likely that it is the culprit.
Yeah, since it's a RHEL 5 machine i don't even get a debug rpm package
=P
I will upgrade all machines and keep monitoring, thanks!
> -Peff
next prev parent reply other threads:[~2013-05-29 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 13:01 git hangs on pthread_join Ian Kumlien
2013-05-23 19:45 ` Martin Fick
2013-05-28 17:51 ` Jeff King
2013-05-29 8:29 ` Ian Kumlien [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-27 13:58 Ian Kumlien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529082903.GC22308@pomac.netswarm.net \
--to=pomac@vapor.com \
--cc=git@vger.kernel.org \
--cc=mfick@codeaurora.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).