From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Thomas Rast <trast@student.ethz.ch>,
Phil Haack <haacked@gmail.com>
Subject: Re: [PATCH] t1300: document some aesthetic failures of the config editor
Date: Fri, 29 Mar 2013 20:21:39 -0400 [thread overview]
Message-ID: <20130330002139.GA32353@sigill.intra.peff.net> (raw)
In-Reply-To: <7vvc8alzat.fsf@alter.siamese.dyndns.org>
On Fri, Mar 29, 2013 at 01:35:22PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Here it is with the updated expectation. I don't care _that_ much, so if
> > you feel strongly and want to drop the first test, feel free.
>
> As long as we are adding expect_failure without an immediate fix,
> let's document the ideal, with this patch on top.
> [...]
> test_expect_failure 'unsetting the last key in a section removes header' '
> cat >.git/config <<-\EOF &&
> + # some generic comment on the configuration file itself
> + # a comment specific to this "section" section.
> [section]
> # some intervening lines
> # that should also be dropped
>
> key = value
> EOF
>
> - >expect &&
> + cat >expect <<-\EOF &&
> + # some generic comment on the configuration file itself
> + EOF
I think we may not attain that ideal without some natural language
processing of the comments. But hey, no reason not to shoot for the
stars. :)
-Peff
next prev parent reply other threads:[~2013-03-30 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 16:29 Minor bug in git branch --set-upstream-to adding superfluous branch section to config Phil Haack
2013-03-29 17:00 ` Jeff King
2013-03-29 17:20 ` Thomas Rast
2013-03-29 17:23 ` Jeff King
2013-03-29 17:50 ` [PATCH] t1300: document some aesthetic failures of the config editor Jeff King
2013-03-29 18:51 ` Junio C Hamano
2013-03-29 19:51 ` Jeff King
2013-03-29 20:35 ` Junio C Hamano
2013-03-30 0:21 ` Jeff King [this message]
2018-03-28 16:33 ` Johannes Schindelin
2018-03-28 17:59 ` Jeff King
2013-03-29 20:00 ` Junio C Hamano
2013-03-29 17:27 ` Minor bug in git branch --set-upstream-to adding superfluous branch section to config Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330002139.GA32353@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=haacked@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).