git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, David Michael Barr <b@rr-dav.id.au>
Subject: Re: [PATH/RFC] Revert "compat: add strtok_r()"
Date: Fri, 1 Feb 2013 12:49:27 -0800	[thread overview]
Message-ID: <20130201204927.GG12368@google.com> (raw)
In-Reply-To: <1359714786-1912-1-git-send-email-kusmabite@gmail.com>

Hi Erik,

Erik Faye-Lund wrote:

> This reverts commit 78457bc0ccc1af8b9eb776a0b17986ebd50442bc.
>
> commit 28c5d9e ("vcs-svn: drop string_pool") previously removed
> the only call-site for strtok_r. So let's get rid of the compat
> implementation as well.

Yes, good idea.  Sorry I didn't take care of this at the time.

> Conflicts:
> 	Makefile
> 	config.mak.in
> 	configure.ac

Since the conflicts were straightforward, I'd drop this or replace it
with a quick description of any surprising choices made in resolving
them.

Thanks.  With the fixup from your reply squashed in,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  parent reply	other threads:[~2013-02-01 20:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 10:33 [PATH/RFC] Revert "compat: add strtok_r()" Erik Faye-Lund
2013-02-01 10:37 ` Erik Faye-Lund
2013-02-01 20:49 ` Jonathan Nieder [this message]
2013-02-25  6:55   ` Junio C Hamano
2013-02-26 16:48     ` Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130201204927.GG12368@google.com \
    --to=jrnieder@gmail.com \
    --cc=b@rr-dav.id.au \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).