git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Cc: git@vger.kernel.org, Per Cederqvist <cederp@opera.com>,
	Theodore Ts'o <tytso@mit.edu>, Iulian Udrea <iulian@linux.com>,
	Axel Beckert <abe@deuxchevaux.org>
Subject: [GUILT] [PATCH 1/7] get rid of "cat: write error: Broken pipe" error message
Date: Tue, 15 Jan 2013 18:27:01 -0800	[thread overview]
Message-ID: <20130116022701.GJ12524@google.com> (raw)
In-Reply-To: <20130116022606.GI12524@google.com>

From: Per Cederqvist <cederp@opera.com>
Date: Tue, 13 Mar 2012 14:39:44 +0100

In some circumstances (like running guilt in a M-x shell buffer in
Emacs) cat may give the above error message when the reader of the
output from cat exits without reading all input from cat.  (In other
circumstances cat is just silently terminated with SIGPIPE.)

Get rid of the error by removing the useless use of cat in
do_get_header and do_get_full_header.

Signed-off-by: Per Cederqvist <cederp@opera.com>
Acked-by: Jeff Sipek <jeffpc@josefsipek.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 guilt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/guilt b/guilt
index d1e17d4..7f6806e 100755
--- a/guilt
+++ b/guilt
@@ -359,7 +359,7 @@ do_get_header()
 	# 4th line skips any empty lines thereafter.
 	# 5th line turns off empty line skip upon seeing a non-empty line.
 	# 6th line terminates execution when we encounter the diff
-	cat "$1" | awk '
+	awk '
 BEGIN{body=0; subj=0}
 /^Subject:/ && (body == 0 && subj == 0){subj=1; print substr($0, 10) "\n"; next}
 /^(Subject:|From:|Author:|Date:|commit)/ && (body == 0){next}
@@ -369,7 +369,7 @@ BEGIN{body=0; subj=0}
 /^(diff |---$|--- )/{exit}
 {print $0}
 END{}
-'
+' < "$1"
 }
 
 # usage: do_get_full_header patchfile
@@ -377,12 +377,12 @@ do_get_full_header()
 {
 	# 2nd line checks for the begining of a patch
 	# 3rd line outputs the line if it didn't get pruned by the above rules
-	cat "$1" | awk '
+	awk '
 BEGIN{}
 /^(diff |---$|--- )/{exit}
 {print $0}
 END{}
-'
+' < "$1"
 }
 
 # usage: assert_head_check
-- 
1.8.1

  reply	other threads:[~2013-01-16  2:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  2:26 [PATCH 0/7] guilt patches, including git 1.8 support Jonathan Nieder
2013-01-16  2:27 ` Jonathan Nieder [this message]
2013-01-16  2:27 ` [GUILT] [PATCH 2/7] The tests should not fail if log.date or log.decorate are set Jonathan Nieder
2013-01-16  2:28 ` [GUILT] [PATCH 3/7] Testsuite: get rid of "Broken pipe" errors from yes Jonathan Nieder
2013-01-16  2:28 ` [GUILT] [PATCH 4/7] Handle empty patches and patches with only a header Jonathan Nieder
2013-01-16  2:29 ` [GUILT] [PATCH 5/7] Fix fatal "guilt graph" error in sha1sum invocation Jonathan Nieder
2013-01-16  2:30 ` [GUILT] [PATCH 6/7] Change git branch when patches are applied Jonathan Nieder
2013-01-16  2:31 ` [GUILT] [PATCH 7/7] Drop unneeded git version check Jonathan Nieder
2013-01-16  3:26 ` [PATCH 0/7] guilt patches, including git 1.8 support Theodore Ts'o
2013-01-16 15:04   ` Josef 'Jeff' Sipek
2013-01-20 21:19 ` Per Cederqvist
2013-01-20 21:24   ` Josef 'Jeff' Sipek
2013-01-27 14:38 ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130116022701.GJ12524@google.com \
    --to=jrnieder@gmail.com \
    --cc=abe@deuxchevaux.org \
    --cc=cederp@opera.com \
    --cc=git@vger.kernel.org \
    --cc=iulian@linux.com \
    --cc=jeffpc@josefsipek.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).