From: Jonathan Nieder <jrnieder@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: git discussion list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/4] t5002: check if unzip supports symlinks
Date: Wed, 9 Jan 2013 23:36:29 -0800 [thread overview]
Message-ID: <20130110073629.GC5121@elie.Belkin> (raw)
In-Reply-To: <50EAFCD7.9090008@lsrfire.ath.cx>
René Scharfe wrote:
> Am 07.01.2013 09:52, schrieb Jonathan Nieder:
>> Hm. Do some implementations of "unzip" not support symlinks, or is
>> the problem that some systems build Info-ZIP without the SYMLINKS
>> option?
>
> The unzip supplied with NetBSD 6.0.1, which is based on libarchive, doesn't
> support symlinks. It creates a file with the link target path as its only
> content for such entries.
Ok, that makes sense. A quick search finds
<https://code.google.com/p/libarchive/issues/detail?id=104>, which if
I understand correctly was fixed in libarchive 3.0.2. NetBSD 6 uses a
patched 2.8.4.
[...]
> For the test script there is no difference: If we don't have a tool to
> verify symlinks in archives, we better skip that part.
Yeah, I just wanted to see if there were other parts of the world that
needed fixing while at it. Thanks for explaining.
Ciao,
Jonathan
prev parent reply other threads:[~2013-01-10 7:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 20:49 [LHF] making t5000 "tar xf" tests more lenient Junio C Hamano
2013-01-05 18:34 ` René Scharfe
2013-01-05 19:43 ` Junio C Hamano
2013-01-05 20:11 ` Junio C Hamano
2013-01-05 22:50 ` René Scharfe
2013-01-05 22:49 ` [PATCH] archive-tar: split long paths more carefully René Scharfe
2013-01-05 23:31 ` Jonathan Nieder
2013-01-06 6:54 ` Junio C Hamano
2013-01-06 15:20 ` [PATCH] archive-zip: write uncompressed size into header even with streaming René Scharfe
2013-01-06 17:45 ` [PATCH 0/4] ZIP test fixes René Scharfe
2013-01-06 17:47 ` [PATCH 1/4] t0024, t5000: clear variable UNZIP, use GIT_UNZIP instead René Scharfe
2013-01-07 5:16 ` Jonathan Nieder
2013-01-07 16:25 ` René Scharfe
2013-01-06 17:49 ` [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP René Scharfe
2013-01-06 18:06 ` Matt Kraai
2013-01-06 21:59 ` René Scharfe
2013-01-07 8:45 ` Jonathan Nieder
2013-01-07 16:28 ` René Scharfe
2013-01-06 17:51 ` [PATCH 3/4] t5000, t5002: move ZIP tests into their own script René Scharfe
2013-01-06 17:59 ` [PATCH 4/4] t5002: check if unzip supports symlinks René Scharfe
2013-01-07 8:52 ` Jonathan Nieder
2013-01-07 16:50 ` René Scharfe
2013-01-10 7:36 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110073629.GC5121@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).