From: Jeff King <peff@peff.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: David Michael Barr <b@rr-dav.id.au>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC] pack-objects: compression level for non-blobs
Date: Sat, 29 Dec 2012 00:07:07 -0500 [thread overview]
Message-ID: <20121229050707.GA14475@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8D_E0shqJAvZH7xqij6F4a6qUxkUPNcZL=0yX5w9bLd_g@mail.gmail.com>
On Sat, Dec 29, 2012 at 11:34:09AM +0700, Nguyen Thai Ngoc Duy wrote:
> On Sat, Dec 29, 2012 at 7:41 AM, Jeff King <peff@peff.net> wrote:
> > I wonder if we could do even better, though. For a traversal, we only
> > need to look at the commit header. We could potentially do a progressive
> > inflate and stop before getting to the commit message (which is the bulk
> > of the data, and the part that is most likely to benefit from
> > compression).
>
> Commit cache should solve this efficiently as it also eliminates
> parsing cost. We discussed this last time as a side topic of the
> reachability bitmap feature.
I agree that a commit cache would solve this (though it can not help the
tree traversal). But just dropping the compression (or doing partial
decompression when we only care about the beginning part) is way less
code and complexity. There's no cache to manage.
-Peff
next prev parent reply other threads:[~2012-12-29 5:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 6:25 [RFC] pack-objects: compression level for non-blobs David Michael Barr
2012-11-26 12:35 ` David Michael Barr
2012-12-29 0:41 ` Jeff King
2012-12-29 4:34 ` Nguyen Thai Ngoc Duy
2012-12-29 5:07 ` Jeff King [this message]
2012-12-29 5:25 ` Nguyen Thai Ngoc Duy
2012-12-29 5:27 ` Jeff King
2012-12-29 9:05 ` Jeff King
2012-12-29 9:48 ` Jeff King
2012-12-30 12:05 ` Jeff King
2012-12-30 12:53 ` Nguyen Thai Ngoc Duy
2012-12-30 21:31 ` Jeff King
2012-12-31 18:06 ` Shawn Pearce
2013-01-01 4:15 ` Duy Nguyen
2013-01-01 12:10 ` Duy Nguyen
2013-01-01 17:17 ` Shawn Pearce
2013-01-01 23:47 ` Junio C Hamano
2013-01-02 2:23 ` Duy Nguyen
2013-01-01 20:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121229050707.GA14475@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=b@rr-dav.id.au \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).