From: Simon Oosthoek <s.oosthoek@xs4all.nl>
To: Junio C Hamano <gitster@pobox.com>
Cc: piotr.krukowiecki@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] make __git_ps1 accept a third parameter in pcmode
Date: Wed, 26 Dec 2012 22:03:24 +0100 [thread overview]
Message-ID: <20121226210324.GA20704@xs4all.nl> (raw)
In-Reply-To: <7vfw2so8q3.fsf@alter.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> [2012-12-26 12:32:20 -0800]:
> The point of the above two was that __git_ps1 does not have to set
> PS1 as long as the insn says user to use PROMPT_COMMAND that sets
> PS1 himself, exactly as illustrated above. In other words, replace
> the last PS1=... in the "prompt command" mode with an echo or
> something and make the user responsible for assigning it to PS1 in
> his PROMPT_COMMAND.
>
> Or put it in another way, I was hoping that we can do without adding
> the prompt command mode---if there is no two modes, there is no need
> to switch between them.
>
> But as I said, there probably is a reason why that approach does not
> work, that is why I said...
>
The only reason to my knowledge is that bash's handling of zero-length strings, like terminal colour commands, is producing a PS1 that outputs less visible characters than bash thinks and thus bash makes mistakes when wrapping the commandline. The way to prevent that is to use \[ and \] around those and that doesn't seem to work from a string produced from command-substitution. (BTW, the colours come through just fine, just the \[ and \] don't)
Another approach could be to split up the functionality and have a few support functions to set various variables (corresponding with the gitstring features, like *%+ characters and colour hints). These variables could then be used by a custom PROMPT_COMMAND function or a command substitution function to produce a gitstring. I suppose that would mean a complete rewrite or very close to it ;-)
/Simon
next prev parent reply other threads:[~2012-12-26 21:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAA01Cso1E4EC4W667FEU_af2=uGOfPuaWEB3y+zPCpB+bPzoaA@mail.gmail.com>
2012-11-28 13:20 ` git-prompt.sh vs leading white space in __git_ps1()::printf_format Simon Oosthoek
[not found] ` <CAA01CspHAHN7se2oJ2WgcmpuRfoa+9Sx9sUvaPEmQ-Y+kDwHhA@mail.gmail.com>
2012-11-28 18:04 ` Piotr Krukowiecki
2012-11-28 20:08 ` Simon Oosthoek
2012-11-28 20:47 ` Junio C Hamano
2012-11-28 20:58 ` Simon Oosthoek
2012-12-11 22:47 ` Simon Oosthoek
2012-12-11 23:04 ` Junio C Hamano
2012-12-12 0:03 ` Junio C Hamano
2012-12-12 8:55 ` Simon Oosthoek
2012-12-12 17:50 ` Junio C Hamano
2012-12-12 20:25 ` Simon Oosthoek
2012-12-26 7:47 ` Junio C Hamano
2012-12-26 12:51 ` Simon Oosthoek
2012-12-26 19:15 ` [PATCH] make __git_ps1 accept a third parameter in pcmode Simon Oosthoek
2012-12-26 19:45 ` Junio C Hamano
2012-12-26 20:19 ` Simon Oosthoek
2012-12-26 20:32 ` Junio C Hamano
2012-12-26 20:54 ` Junio C Hamano
2012-12-26 21:03 ` Simon Oosthoek [this message]
2012-12-26 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121226210324.GA20704@xs4all.nl \
--to=s.oosthoek@xs4all.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=piotr.krukowiecki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).