git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation: don't link to example mail addresses
Date: Sat, 15 Dec 2012 12:20:18 -0500	[thread overview]
Message-ID: <20121215172018.GA18696@sigill.intra.peff.net> (raw)
In-Reply-To: <20121215150314.GC2725@river.lan>

On Sat, Dec 15, 2012 at 03:03:15PM +0000, John Keeping wrote:

> Mail addresses in documentation are converted into mailto: hyperlinks in
> the HTML output and footnotes in man pages.  This isn't desirable for
> cases where the address is used as an example and is not valid.
> 
> Particularly annoying is the example "jane@laptop.(none)" which appears
> in git-shortlog(1) as "jane@laptop[1].(none)", with note 1 saying:
> 
> 	1. jane@laptop
> 	   mailto:jane@laptop

Thanks, this is definitely worth fixing.

> Fix this by quoting example mail addresses with "$$", preventing
> Asciidoc from processing them.
> 
> In the case of mailmap.txt, render the address monospaced so that it
> matches the block examples surrounding that paragraph.

I think I'd just render them monospace everywhere. We are very
inconsistent about which form of quotes we use in the documentation (I
think because most of the developers read the source directly and not
the rendered asciidoc). And then we don't have to worry about the "$$"
construct (and IMHO it makes the source much more readable, and marking
the address as a literal looks good in the output, too).

-Peff

  reply	other threads:[~2012-12-15 17:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15 15:03 [PATCH] Documentation: don't link to example mail addresses John Keeping
2012-12-15 17:20 ` Jeff King [this message]
2012-12-15 18:00   ` Junio C Hamano
2012-12-15 18:24   ` John Keeping
2012-12-16 12:04     ` Jeff King
2012-12-16 14:00       ` [PATCH v2] " John Keeping
2012-12-16 18:48         ` Junio C Hamano
2012-12-17  2:24         ` Junio C Hamano
2012-12-17 12:02           ` Jeff King
2012-12-17 19:57             ` Junio C Hamano
2012-12-17  5:29 ` [PATCH] " Junio C Hamano
2012-12-17  9:44   ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121215172018.GA18696@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).