git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Eric S. Raymond" <esr@thyrsus.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add documentation on how to integrate commands.
Date: Mon, 26 Nov 2012 00:25:00 -0500	[thread overview]
Message-ID: <20121126052500.GA15605@thyrsus.com> (raw)
In-Reply-To: <7vy5hpvukk.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com>:
> As the first sentence in this paragraph does not make it clear
> enough that you are defining a new term "git execution directory",
> "execution directory" here may be misleading and can easily be
> mistaken as if we look something in the directory where the user
> runs "git" in.  We usually call it "exec path".

Fixed.

> Actually, we tend to avoid Python dependency for anything important
> and allow it only on fringes; people who lack Python environment are
> not missing much, and we would want to keep it that way until the
> situation on the Windows front changes.

Added:

    Python is fine for import utilities, surgical tools, remote helpers
    and other code at the edges of the git suite - but it should not yet
    be used for core functions. This may change in the future; the problem
    is that we need better Python integration in the git Windows installer
    before we can be confident people in that environment won't
    experience an unacceptably large loss of capability.

I will also take this as a part-resolution of the related policy thread. 
Issue perhaps to be revisited when the Windows port gets the Python support
to a good state.

I will submit for separate consideration a patch proposing the following
new guidelines:

1. Python code SHOULD NOT require an interpreter version newer than 2.6.

2. Python code SHOULD check the interpreter version and exit gracefully
   with an explanation if it detects that its dependency cannot be satisfied.

> I would prefer to see this sentence not call libgit.a a "library".
> We primarily use libgit.a to let linker pick necessary object files
> without us having to list object files for non-builtin command
> implementations and it is not designed to be used by other people.

Fixed.  I now refer to it as a "collection of functions".

> And when sending a patch in, do not forget to sign off your patches
> ;-)

Added.  I will submit a third time with a signoff. :-)
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

      reply	other threads:[~2012-11-26  5:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24 12:23 [PATCH] Add documentation on how to integrate commands Eric S. Raymond
2012-11-24 15:11 ` Pete Wyckoff
2012-11-24 15:23   ` Eric S. Raymond
2012-11-25  0:06   ` Eric S. Raymond
2012-11-25  7:12 ` Michael Haggerty
2012-11-25  8:29   ` Eric S. Raymond
2012-11-26  4:47 ` Junio C Hamano
2012-11-26  5:25   ` Eric S. Raymond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121126052500.GA15605@thyrsus.com \
    --to=esr@thyrsus.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).