From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Subject: Re: [PATCH v6 2/3] completion: add new __gitcompadd helper
Date: Wed, 31 Oct 2012 15:15:20 +0100 [thread overview]
Message-ID: <20121031141520.GB26072@goldbirke> (raw)
In-Reply-To: <CAMP44s0dctpjobNNRTOFcX4ir+nzenTZMNWFbEvBa-QU93psbA@mail.gmail.com>
On Wed, Oct 31, 2012 at 12:05:34AM +0100, Felipe Contreras wrote:
> On Tue, Oct 30, 2012 at 11:58 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> > On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote:
> >> The idea is to never touch the COMPREPLY variable directly.
> >>
> >> This allows other completion systems override __gitcompadd, and do
> >> something different instead.
> >>
> >> Also, this allows the simplification of the completion tests (separate
> >> patch).
> >
> > This doesn't apply anymore, does it? The mentioned simplification is
> > done in the other series.
>
> Yeah, but you mentioned you didn't like all the COMPREPLY=() changes
> and it might be time to get rid of them.
>
> So this series supersedes that one.
COMPREPLY=() has nothing to do with it. My point is that there is no
"separate patch" that performs the alleged simplification made
possible by this patch, therefore that sentence should have been
removed from the log message for the resubmission.
next prev parent reply other threads:[~2012-10-31 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 1:45 [PATCH v6 0/3] completion: refactor and zsh wrapper Felipe Contreras
2012-10-22 1:45 ` [PATCH v6 1/3] completion: get rid of empty COMPREPLY assignments Felipe Contreras
2012-10-22 1:45 ` [PATCH v6 2/3] completion: add new __gitcompadd helper Felipe Contreras
2012-10-30 22:58 ` SZEDER Gábor
2012-10-30 23:05 ` Felipe Contreras
2012-10-31 14:15 ` SZEDER Gábor [this message]
2012-10-22 1:45 ` [PATCH v6 3/3] completion: add new zsh completion Felipe Contreras
2012-10-30 16:15 ` [PATCH v6 0/3] completion: refactor and zsh wrapper Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031141520.GB26072@goldbirke \
--to=szeder@ira.uka.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).