From: Jeff King <peff@peff.net>
To: Eric Wong <normalperson@yhbt.net>
Cc: "Gunnlaugur Þór Briem" <gunnlaugur@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Document git-svn fetch --log-window-size parameter
Date: Fri, 26 Oct 2012 09:32:50 -0400 [thread overview]
Message-ID: <20121026133250.GI1455@sigill.intra.peff.net> (raw)
In-Reply-To: <20121026094602.GA7887@dcvr.yhbt.net>
On Fri, Oct 26, 2012 at 09:46:02AM +0000, Eric Wong wrote:
> > Thanks. Your description makes sense to me, but I do not have enough
> > git-svn knowledge to know if it covers all intended uses of the flag.
> > Eric?
> >
> > > +--log-window-size=<n>;;
> > > + Fetch <n> log entries per request when scanning Subversion history.
> > > + The default is 100. For very large Subversion repositories, larger
> > > + values may be needed for 'clone'/'fetch' to complete in reasonable
> > > + time. But overly large values may lead to request timeouts.
>
> Overly large values also lead to excessive memory usage. I may have
> only had 256M in my dev machine at the time I added this parameter:
That's probably worth mentioning. Gunnlaugur, any objection to me
amending your commit with:
diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index 64756c9..8b0d3ad 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -150,7 +150,8 @@ Skip "branches" and "tags" of first level directories;;
Fetch <n> log entries per request when scanning Subversion history.
The default is 100. For very large Subversion repositories, larger
values may be needed for 'clone'/'fetch' to complete in reasonable
- time. But overly large values may lead to request timeouts.
+ time. But overly large values may lead to higher memory usage and
+ request timeouts.
'clone'::
Runs 'init' and 'fetch'. It will automatically create a
?
-Peff
next prev parent reply other threads:[~2012-10-26 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 10:33 [PATCH] Document git-svn fetch --log-window-size parameter Gunnlaugur Þór Briem
2012-10-25 9:52 ` Jeff King
2012-10-26 9:46 ` Eric Wong
2012-10-26 13:32 ` Jeff King [this message]
2012-10-26 13:45 ` Gunnlaugur Thor Briem
2012-10-29 20:18 ` Eric Wong
2012-10-29 22:02 ` Jeff King
2012-10-29 22:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026133250.GI1455@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gunnlaugur@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).