From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] config: treat user and xdg config permission problems as errors
Date: Sun, 14 Oct 2012 02:22:18 -0400 [thread overview]
Message-ID: <20121014062218.GB13477@sigill.intra.peff.net> (raw)
In-Reply-To: <20121014000402.GB11399@elie.Belkin>
On Sat, Oct 13, 2012 at 05:04:02PM -0700, Jonathan Nieder wrote:
> Better to error out and ask the user to correct the problem.
>
> This only affects the user and xdg config files, since the user
> presumably has enough access to fix their permissions. If the system
> config file is unreadable, the best we can do is to warn about it so
> the user knows to notify someone and get on with work in the meantime.
I'm on the fence about treating the systme config specially. On the one
hand, I see the convenience if somebody has a bogus /etc/gitconfig and
gets EPERM but can't fix it. On the other hand, if we get EIO, isn't
that a good indication that we would want to die?
For example, servers may depend on /etc/gitconfig to enforce security
policy (e.g., setting transfer.fsckObjects or receive.deny*). Perhaps
our default should be safe, and people can use GIT_CONFIG_NOSYSTEM to
work around a broken machine.
-Peff
next prev parent reply other threads:[~2012-10-14 6:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 0:02 [RFC/PATCH 0/2] Re: [PATCH] config: warn on inaccessible files Jonathan Nieder
2012-10-14 0:03 ` [PATCH 1/2] config, gitignore: failure to access with ENOTDIR is ok Jonathan Nieder
2012-10-14 0:04 ` [PATCH 2/2] config: treat user and xdg config permission problems as errors Jonathan Nieder
2012-10-14 6:22 ` Jeff King [this message]
2012-10-14 8:42 ` Jonathan Nieder
2012-10-14 8:44 ` [PATCH 3/2] config doc: advertise GIT_CONFIG_NOSYSTEM Jonathan Nieder
2012-10-14 8:53 ` [PATCH v2 3/2] " Jonathan Nieder
2012-10-14 8:46 ` [PATCH 4/2] config: exit on error accessing any config file Jonathan Nieder
2012-10-14 16:43 ` [PATCH 2/2] config: treat user and xdg config permission problems as errors Jeff King
2012-10-14 4:55 ` [RFC/PATCH 0/2] Re: [PATCH] config: warn on inaccessible files Junio C Hamano
2012-10-14 6:26 ` Jeff King
2012-10-14 9:00 ` Jonathan Nieder
2012-10-14 6:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121014062218.GB13477@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).