From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: Brad Hein <linuxbrad@gmail.com>, git@vger.kernel.org
Subject: Re: git fails: segfault at 0 ip 00000000004076d5 sp 00007fff7806ebc0
Date: Fri, 12 Oct 2012 13:12:56 -0400 [thread overview]
Message-ID: <20121012171256.GA21409@sigill.intra.peff.net> (raw)
In-Reply-To: <CABPQNSbRYq43rADP6BaQ_Q2SB+M76rHdX3hOSpGQk2c5UNR5hg@mail.gmail.com>
On Fri, Oct 12, 2012 at 06:34:30PM +0200, Erik Faye-Lund wrote:
> > Thanks for reporting. I gave it a quick go, and the issue seems to
> > also be present in the current 'master'.
> >
> > The problem is a NULL-pointer dereferencing introduced in 8809703
> > ("http: factor out http error code handling"), where the code assume
> > that slot->results still points to http_request::results. This
> > assumption seems to be wrong.
> >
> > This seems to step around the issue, but I don't know if
> > http_request::results should be set to NULL in the first place. Jeff?
>
> OK, it seems I jumped the gun, and Jeff already sent out a patch for
> it. Nevermind me, then :)
Independent verification is never a bad thing. :)
-Peff
prev parent reply other threads:[~2012-10-12 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJa+X0OkzAX9E2SnDmU=on0yzzVZ9OMa2dJZgKMK=gQu2Rhf_Q@mail.gmail.com>
2012-10-12 4:58 ` git fails: segfault at 0 ip 00000000004076d5 sp 00007fff7806ebc0 Brad Hein
2012-10-12 6:22 ` [PATCH] http: fix segfault in handle_curl_result Jeff King
2012-10-12 7:30 ` Jeff King
2012-10-12 7:35 ` [PATCH 1/2] remote-curl: do not call run_slot repeatedly Jeff King
2012-10-12 7:35 ` [PATCH 2/2] http: do not set up curl auth after a 401 Jeff King
2012-10-12 13:39 ` Brad Hein
2012-10-12 16:46 ` [PATCH] http: fix segfault in handle_curl_result Junio C Hamano
2012-10-12 16:29 ` git fails: segfault at 0 ip 00000000004076d5 sp 00007fff7806ebc0 Erik Faye-Lund
2012-10-12 16:34 ` Erik Faye-Lund
2012-10-12 17:12 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012171256.GA21409@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=linuxbrad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).