git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Ackermann <th.acker66@arcor.de>, git@vger.kernel.org
Subject: Re: [Patch 1/5] Fix some asciidoc layout problems
Date: Sat, 6 Oct 2012 15:10:09 -0400	[thread overview]
Message-ID: <20121006191009.GB3644@sigill.intra.peff.net> (raw)
In-Reply-To: <7vfw5rqwby.fsf@alter.siamese.dyndns.org>

On Sat, Oct 06, 2012 at 11:39:13AM -0700, Junio C Hamano wrote:

> Thomas Ackermann <th.acker66@arcor.de> writes:
> 
> > Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> > ---
> >  Documentation/git-bisect-lk2009.txt | 12 ++++++------
> >  Documentation/git-fetch-pack.txt    |  5 ++++-
> >  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> You didn't say what "layout problem" you are fixing, or what the
> approach you took to "fix" it.  From the patch, I can guess that the
> latter is to lengthen the lines that surround the displayed examples,
> but as far as I know and can tell, the existing ones are long enough
> so I cannot tell why you needed such a change to the source in the
> first place.
> 
> A better explanation, please?

I had the same question. Also, some of the lines convert tabs in literal
output into spaces, which is actively wrong (or maybe they were
converted already to spaces in the current code, but they should at
least align with 8-space tabstops):

> > -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M      Makefile
> > +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M  Makefile

-Peff

  reply	other threads:[~2012-10-06 19:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-06 15:51 [Patch 0/5] Create single PDF for all HTML files Thomas Ackermann
2012-10-06 15:53 ` [Patch 1/5] Fix some asciidoc layout problems Thomas Ackermann
2012-10-06 18:39   ` Junio C Hamano
2012-10-06 19:10     ` Jeff King [this message]
2012-10-07  8:01     ` Aw: " Thomas Ackermann
2012-10-06 15:55 ` [Patch 2/5] Create html documents for all files in Documentation/technical Thomas Ackermann
2012-10-06 18:45   ` Philip Oakley
2012-10-06 15:55 ` [Patch 3/5] Create html documents for all files in Documentation/RelNotes Thomas Ackermann
2012-10-06 18:48   ` Philip Oakley
2012-10-06 19:21   ` Jeff King
2012-10-07 20:53     ` Junio C Hamano
2012-10-15 11:48       ` Michael J Gruber
2012-10-15 20:49         ` Junio C Hamano
2012-10-06 15:57 ` [Patch 4/5] Create html documents for all files in Documentation/howto Thomas Ackermann
2012-10-06 15:58 ` [Patch 5/5] Create pdf from all html files Thomas Ackermann
2012-10-06 19:11   ` Jeff King
2012-10-06 19:32 ` [Patch 0/5] Create single PDF for all HTML files Jeff King
2012-10-07 20:54   ` Junio C Hamano
2012-10-07  8:14 ` Aw: " Thomas Ackermann
2012-10-07 22:52   ` Jeff King
2012-10-15 11:55     ` Michael J Gruber
2012-10-15 17:42       ` Jeff King
2012-10-08 22:53   ` Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121006191009.GB3644@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=th.acker66@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).