From: Jeff King <peff@peff.net>
To: Paul Mackerras <paulus@samba.org>
Cc: Scott Batchelor <scott.batchelor@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: refresh the index before running diff-files
Date: Sat, 29 Sep 2012 21:42:04 -0400 [thread overview]
Message-ID: <20120930014203.GA10664@sigill.intra.peff.net> (raw)
In-Reply-To: <20120930000527.GB4852@bloggs.ozlabs.ibm.com>
On Sun, Sep 30, 2012 at 10:05:27AM +1000, Paul Mackerras wrote:
> On Fri, Sep 28, 2012 at 04:50:54PM -0400, Jeff King wrote:
>
> > +proc refresh_index {} {
> > + global need_index_refresh
> > + if { $need_index_refresh } {
> > + exec sh -c "git update-index --refresh >/dev/null 2>&1 || true"
> > + set need_index_refresh false
> > + }
> > +}
>
> Unfortunately this will wait for the git update-index command to
> complete, making the GUI unresponsive while it executes, and that can
> take minutes on a large repository (e.g. the linux kernel) on a
> machine with a slow disk and a cold disk cache. We will need to make
> the git update-index execute asynchronously.
Good point. We're getting out of my very limited tcl cargo-culting
skills now, so I'll let somebody more clueful do that fix.
-Peff
next prev parent reply other threads:[~2012-09-30 1:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 18:55 Git diff-file bug? Scott Batchelor
2012-09-28 20:23 ` Jeff King
2012-09-28 20:50 ` [PATCH] gitk: refresh the index before running diff-files Jeff King
2012-09-28 21:40 ` Junio C Hamano
2012-09-28 22:11 ` Andreas Schwab
2012-09-28 22:31 ` Jeff King
2012-09-28 23:02 ` Junio C Hamano
2012-09-28 23:04 ` Jeff King
2012-09-28 23:18 ` Junio C Hamano
2012-09-28 23:20 ` Andreas Schwab
2012-09-30 0:05 ` Paul Mackerras
2012-09-30 1:42 ` Jeff King [this message]
2012-09-30 20:34 ` Jonathan Nieder
2012-10-01 22:32 ` Jeff King
2012-10-01 22:54 ` Junio C Hamano
2012-09-28 20:40 ` Git diff-file bug? Junio C Hamano
2012-10-03 8:04 ` Scott Batchelor
2012-10-03 11:58 ` Drew Northup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120930014203.GA10664@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=scott.batchelor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).