From: Jeff King <peff@peff.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] add basic lua infrastructure
Date: Tue, 25 Sep 2012 00:53:45 -0400 [thread overview]
Message-ID: <20120925045345.GA5708@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8ArwPq=YRAddVtC+m8X0+=tndb2-=tmiMS=m2VX3TWGYg@mail.gmail.com>
On Tue, Sep 25, 2012 at 08:55:23AM +0700, Nguyen Thai Ngoc Duy wrote:
> On Tue, Sep 25, 2012 at 7:25 AM, Jeff King <peff@peff.net> wrote:
> > +ifdef USE_LUA
> > + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2`
> > + EXTLIBS += `pkg-config --libs lua5.2`
> > +endif
> > +
>
> I remember we paid noticeable penalty when linking with libcurl to
> main git binary and Linus removed libcurl from main git, moving it to
> git-http-*. Do we pay similar penalty linking to liblua?
I don't think so. The real problem with libcurl is that it brings in a
ton of other libraries:
$ ldd /usr/lib/x86_64-linux-gnu/libcurl.so | awk '{print $1}'
linux-vdso.so.1
libidn.so.11
libssh2.so.1
liblber-2.4.so.2
libldap_r-2.4.so.2
librt.so.1
libgssapi_krb5.so.2
libssl.so.1.0.0
libcrypto.so.1.0.0
librtmp.so.0
libz.so.1
libc.so.6
libgcrypt.so.11
libresolv.so.2
libsasl2.so.2
libgnutls.so.26
libpthread.so.0
/lib64/ld-linux-x86-64.so.2
libkrb5.so.3
libk5crypto.so.3
libcom_err.so.2
libkrb5support.so.0
libdl.so.2
libkeyutils.so.1
libgpg-error.so.0
libtasn1.so.3
libp11-kit.so.0
Compare with lua:
$ ldd /usr/lib/x86_64-linux-gnu/liblua5.2.so | awk '{print $1}'
linux-vdso.so.1
libm.so.6
libdl.so.2
libc.so.6
/lib64/ld-linux-x86-64.so.2
The original timings from Linus are here:
http://article.gmane.org/gmane.comp.version-control.git/123946
The main issue is really hitting all those libraries on a cold cache.
Here are before-and-after timings of:
echo 3 >/proc/sys/vm/drop_caches && git
which should basically just measure startup time. All times are
best-of-five.
[before]
real 0m0.065s
user 0m0.000s
sys 0m0.004s
[after]
real 0m0.063s
user 0m0.000s
sys 0m0.004s
So we actually did better, though the difference is well within the
run-to-run noise. I don't think it's a big deal.
-Peff
next prev parent reply other threads:[~2012-09-25 4:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 0:23 [RFC/PATCH 0/3] git log --pretty=lua Jeff King
2012-09-25 0:24 ` [PATCH 1/3] pretty: make some commit-parsing helpers more public Jeff King
2012-09-25 0:25 ` [PATCH 2/3] add basic lua infrastructure Jeff King
2012-09-25 1:55 ` Nguyen Thai Ngoc Duy
2012-09-25 4:53 ` Jeff King [this message]
2012-09-25 3:21 ` Robin H. Johnson
2012-09-25 3:42 ` Jeff King
2012-09-25 21:18 ` Junio C Hamano
2012-09-25 0:25 ` [PATCH 3/3] add a "lua" pretty format Jeff King
2012-10-06 17:33 ` Jeff King
2012-09-25 11:22 ` [RFC/PATCH 0/3] git log --pretty=lua Nguyen Thai Ngoc Duy
2012-09-25 13:49 ` Stephen Bash
2012-09-25 15:19 ` Matthieu Moy
2012-09-25 16:40 ` Junio C Hamano
2012-09-30 4:31 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925045345.GA5708@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).