From: Jeff King <peff@peff.net>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] add basic lua infrastructure
Date: Mon, 24 Sep 2012 23:42:11 -0400 [thread overview]
Message-ID: <20120925034211.GC3656@sigill.intra.peff.net> (raw)
In-Reply-To: <robbat2-20120925T032006-952720661Z@orbis-terrarum.net>
On Tue, Sep 25, 2012 at 03:21:10AM +0000, Robin H. Johnson wrote:
> On Mon, Sep 24, 2012 at 08:25:12PM -0400, Jeff King wrote:
> > +ifdef USE_LUA
> > + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2`
> > + EXTLIBS += `pkg-config --libs lua5.2`
> > +endif
> Can you please hoist the packagename out to a variable? It's just plain
> "lua" on Gentoo.
Yeah. I mentioned these patches were very rough, but I didn't go into
detail on all the bad points. That is definitely one of them. I have no
idea what the "normal" name is; my debian system sticks the version
number in to allow multiple concurrent versions.
I was hoping somebody with more Lua experience could tell me what's
usual. It would be nice if it just worked out of the box as soon as you
said USE_LUA, but that may not be realistic.
-Peff
next prev parent reply other threads:[~2012-09-25 3:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 0:23 [RFC/PATCH 0/3] git log --pretty=lua Jeff King
2012-09-25 0:24 ` [PATCH 1/3] pretty: make some commit-parsing helpers more public Jeff King
2012-09-25 0:25 ` [PATCH 2/3] add basic lua infrastructure Jeff King
2012-09-25 1:55 ` Nguyen Thai Ngoc Duy
2012-09-25 4:53 ` Jeff King
2012-09-25 3:21 ` Robin H. Johnson
2012-09-25 3:42 ` Jeff King [this message]
2012-09-25 21:18 ` Junio C Hamano
2012-09-25 0:25 ` [PATCH 3/3] add a "lua" pretty format Jeff King
2012-10-06 17:33 ` Jeff King
2012-09-25 11:22 ` [RFC/PATCH 0/3] git log --pretty=lua Nguyen Thai Ngoc Duy
2012-09-25 13:49 ` Stephen Bash
2012-09-25 15:19 ` Matthieu Moy
2012-09-25 16:40 ` Junio C Hamano
2012-09-30 4:31 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925034211.GC3656@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).