From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguy� n Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] Build in gettext poison feature unconditionally
Date: Mon, 20 Aug 2012 22:24:04 -0700 [thread overview]
Message-ID: <20120821052404.GB55686@mannheim-rule.local> (raw)
In-Reply-To: <1345523970-14914-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> The runtime cost should be small. "gcc -O2" inlines _() and
> use_gettext_poison(). But even if it does not, performance should not
> be impacted as _() calls are usually not on critical path. If some of
> them are, we better fix there as gettext() may or may not be cheap
> anyway.
That seems reasonable to me. The increase in code size of a commonly
inlined function and the extra "if" in a common if not
performance-critical codepath is annoying (and I'd prefer to keep
use_gettext_poison() un-inlined), but in any event the cost would go
away once the translation-based implementation of poison lands.
[...]
> I don't know the story behind this compile-time switch. The series [1]
> that introduces it does not say much.
I think it was just paranoia about performance regressions.
> This at least makes it easier for me to run poison tests instead of
> building another binary, if I remember it. Next step could be make
> "make test" run both normal and poison modes, but I'm not sure how to
> do it nicely yet.
Yes, that would be nice (or perhaps a mode to run most tests in
the current locale and rerun test assertions that use a test_i18n*
helper or C_LOCALE_OUTPUT prerequisite in the C locale).
Hope that helps,
Jonathan
next prev parent reply other threads:[~2012-08-21 5:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 4:39 [PATCH] Build in gettext poison feature unconditionally Nguyễn Thái Ngọc Duy
2012-08-21 5:24 ` Jonathan Nieder [this message]
2012-08-21 16:37 ` Junio C Hamano
2012-08-22 5:27 ` [PATCH] Support generate poison .mo files for testing Nguyễn Thái Ngọc Duy
2012-08-22 11:13 ` Junio C Hamano
2012-08-22 12:37 ` Nguyen Thai Ngoc Duy
2012-08-22 16:22 ` Junio C Hamano
2012-08-23 10:53 ` Nguyen Thai Ngoc Duy
2012-08-22 16:43 ` Junio C Hamano
2012-08-23 11:00 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821052404.GB55686@mannheim-rule.local \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).