From: Jeff King <peff@peff.net>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] checkout: default to quiet if !isatty(2).
Date: Thu, 24 May 2012 02:10:00 -0400 [thread overview]
Message-ID: <20120524061000.GA14035@sigill.intra.peff.net> (raw)
In-Reply-To: <1337839534-7760-1-git-send-email-apenwarr@gmail.com>
On Thu, May 24, 2012 at 02:05:34AM -0400, Avery Pennarun wrote:
> It would probably be better to have progress.c check isatty(2) all the time,
> but that wouldn't allow things like 'git push --progress' to force progress
> reporting to on, so I won't try to solve the general case right now.
This looks better. There is a slight inaccuracy in your subject line,
though. We are not defaulting to quiet if !isatty(2) in all cases, but
rather only when we call into unpack_trees, which generates the progress
output. We will still print the ahead/behind line, detached HEAD info,
etc.
Which I think is the right behavior, but is not quite what is advertised
by your commit message.
-Peff
next prev parent reply other threads:[~2012-05-24 6:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 5:18 [PATCH] progress: don't print if !isatty(2) Avery Pennarun
2012-05-24 5:45 ` Jeff King
2012-05-24 6:05 ` [PATCH] checkout: default to quiet " Avery Pennarun
2012-05-24 6:10 ` Jeff King [this message]
2012-05-24 6:12 ` [PATCH v2] checkout: no progress messages " Avery Pennarun
2012-05-24 18:29 ` Junio C Hamano
2012-05-24 18:34 ` Jeff King
2012-05-24 18:49 ` Avery Pennarun
2012-05-24 18:46 ` Avery Pennarun
2012-05-24 21:46 ` Junio C Hamano
2012-05-24 6:12 ` [PATCH] checkout: default to quiet " Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524061000.GA14035@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).