git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Steven Walter <stevenrwalter@gmail.com>
Cc: avarab@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip
Date: Wed, 23 May 2012 20:02:55 -0700	[thread overview]
Message-ID: <20120524030255.GA23382@dcvr.yhbt.net> (raw)
In-Reply-To: <1337820046-4791-1-git-send-email-stevenrwalter@gmail.com>

Steven Walter <stevenrwalter@gmail.com> wrote:

I'll wait for input on others who understand mergeinfo better than
I do to chime in on the actual changes.  Some nits on the tests:

> +# Copyright (c) 2010 Steven Walter

2010?

> +test_expect_success 'verify merge commit' 'x=$(git rev-parse HEAD^2) &&
> +	y=$(git rev-parse branch2) &&
> +	[ $x == $y ]

== is a bash-ism, and we prefer 'test'.  A single '=' works fine here,
but it's probably better to prefix and quote if you're paranoid:

	test "x$x" = "x$y"

  parent reply	other threads:[~2012-05-24  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24  0:40 [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip Steven Walter
2012-05-24  0:40 ` [PATCH 2/2] git-svn.perl: keep processing all commits in parents_exclude Steven Walter
2012-05-24  3:02 ` Eric Wong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-19 19:33 [PATCH v3 " Eric Wong
2012-08-20  1:39 ` [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip Steven Walter
2012-08-21 22:05   ` Eric Wong
2012-08-21 22:38     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524030255.GA23382@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=stevenrwalter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).