git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Are author names ending with a dot invalid?
Date: Fri, 18 May 2012 20:23:35 -0400	[thread overview]
Message-ID: <20120519002335.GD765@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s2OoxUVFE57e8C2Km7rcGn88KkLXxdaA3s5RE6nZ7TU=A@mail.gmail.com>

On Fri, May 18, 2012 at 02:14:57AM +0200, Felipe Contreras wrote:

> It looks like authors ending with a dot ('Foo Jr. <foo@bar.com>') are
> converted without a dot ('Foo Jr <foo@bar.com>') is that intentional?

I was just digging in this code today, and I noticed the same thing. The
culprit is ident.c:copy, which strips magic characters from the
beginning, end, and middle. Except that the set of magic characters is
different at the edges (see ident.c:crud), and in the middle ("<", ">",
"\n").

This dates all the way back to 6aa33f4 (Abstract out the "name <email>
date" handling of commit-tree.c, 2005-07-12), which in turn was adapting
code from earlier (though it also has the issue).

So I think it's intentional, but I also think it's wrong, and it's
simply that nobody has complained about it, because it's not that
common.

-Peff

      reply	other threads:[~2012-05-19  0:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  0:14 Are author names ending with a dot invalid? Felipe Contreras
2012-05-19  0:23 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120519002335.GD765@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).