From: Antonio Ospite <ospite@studenti.unina.it>
To: git@vger.kernel.org
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: Feature idea: git rebase --exec $CMD
Date: Sun, 6 May 2012 12:44:20 +0200 [thread overview]
Message-ID: <20120506124420.bc796b6e2852e6aec5da36d8@studenti.unina.it> (raw)
In-Reply-To: <vpqobq1mxru.fsf@bauges.imag.fr>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On Sun, 06 May 2012 12:03:49 +0200
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> Antonio Ospite <ospite@studenti.unina.it> writes:
>
> > Maybe this -x option should conflict with -i to simplify its "execute
> > the command after each commit" semantics (what if it is combined with -i
> > and 'x/exec' lines?).
>
> Actually, implementation-wise, it's simpler to have '-x' imply '-i', and
> suggest a todo-list containing 'x' lines. Then, the code would simply
> have to add these "x whatever" lines, and let the
> "git-rebase--interactive.sh" mechanics do the job. That would show the
> "x whatever" lines to the user, but that can be seen as added value,
> since it gives an opportunity to the user to remove or edit some of them
> if needed.
>
Thanks Matthieu,
this sounds like a reasonable default behavior for the case of '-x' and
'-i' _combined_, but I still think '-x' with no invocation of $EDITOR
can have its use case (e.g. a "make validate-commits" calling 'git
rebase -x "make test" master').
But I'd like to hear other opinions about that.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-05-06 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 11:26 Feature idea: git rebase --exec $CMD Antonio Ospite
2012-05-05 11:54 ` Felipe Contreras
2012-05-06 10:03 ` Matthieu Moy
2012-05-06 10:44 ` Antonio Ospite [this message]
2012-05-06 12:26 ` Jeff King
2012-05-10 8:28 ` Matthieu Moy
2012-05-23 15:12 ` dag
2012-05-23 15:41 ` Matthieu Moy
2012-05-23 15:50 ` dag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506124420.bc796b6e2852e6aec5da36d8@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).