From: Jeff King <peff@peff.net>
To: demerphq <demerphq@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: General support for ! in git-config values
Date: Thu, 2 Feb 2012 04:54:32 -0500 [thread overview]
Message-ID: <20120202095432.GA19356@sigill.intra.peff.net> (raw)
In-Reply-To: <CANgJU+X2dRP__PFAywGEisDS3xyF7fSszSQG6BO61j2TMKL3Qg@mail.gmail.com>
On Thu, Feb 02, 2012 at 10:44:05AM +0100, demerphq wrote:
> The general design of git seems to me to be based around providing
> building blocks that people can use to build new and interesting tools
> on top of, and so it seems counter to that philosophy to reject an
> feature based on speculative security issues that really can't be
> decided in advance but must instead be decided on a case by case
> basis.
I can't speak for Junio, but I am certainly not rejecting it. Only
saying that it needs to be thought through, and the utility weighed
against the costs. So far I haven't seen an actual patch to comment on
(or even a proposed syntax beyond starting a string with "!", which I
think is a non-starter due to conflicting with existing uses), nor have
I seen a concrete use case (you mentioned pulling the name/email from
ldap, but you also mentioned that there are lots of other ways of
solving that particular problem, so it's not especially compelling).
I'd be happy to hear a more concrete proposal.
-Peff
next prev parent reply other threads:[~2012-02-02 9:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 17:33 General support for ! in git-config values Ævar Arnfjörð Bjarmason
2012-02-01 18:40 ` Jeff King
2012-02-01 21:25 ` Ævar Arnfjörð Bjarmason
2012-02-01 22:21 ` Junio C Hamano
2012-02-02 0:16 ` demerphq
2012-02-02 0:27 ` Junio C Hamano
2012-02-02 1:14 ` demerphq
2012-02-02 1:39 ` Junio C Hamano
2012-02-02 1:57 ` demerphq
2012-02-02 2:38 ` Jeff King
2012-02-02 9:44 ` demerphq
2012-02-02 9:54 ` Jeff King [this message]
2012-02-02 10:21 ` demerphq
2012-02-03 5:08 ` Kyle Moffett
2012-02-03 6:11 ` Junio C Hamano
2012-02-03 7:35 ` Kyle Moffett
2012-02-03 12:13 ` Jeff King
2012-02-03 12:09 ` Jeff King
2012-02-02 1:41 ` Junio C Hamano
2012-02-02 2:06 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202095432.GA19356@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).