From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>, git@vger.kernel.org
Subject: Re: Bug: "git checkout -b" should be allowed in empty repo
Date: Mon, 30 Jan 2012 16:50:43 -0500 [thread overview]
Message-ID: <20120130215043.GB16149@sigill.intra.peff.net> (raw)
In-Reply-To: <7vaa55ar4v.fsf@alter.siamese.dyndns.org>
On Mon, Jan 30, 2012 at 12:10:08PM -0800, Junio C Hamano wrote:
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index f1984d9..195c40b 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
> @@ -922,6 +922,19 @@ static int parse_branchname_arg(int argc, const char **argv,
> return argcount;
> }
>
> +static int switch_unborn_to_new_branch(struct checkout_opts *opts, const char *old_ref)
> +{
> + int status;
> + struct strbuf branch_ref = STRBUF_INIT;
> +
> + strbuf_addf(&branch_ref, "refs/heads/%s", opts->new_branch);
> + warning(_("Leaving the unborn branch '%s' behind..."),
> + skip_prefix(old_ref, "refs/heads/"));
> + status = create_symref("HEAD", branch_ref.buf, "checkout -b");
> + strbuf_reset(&branch_ref);
> + return status;
> +}
Is it really worth warning? After all, by definition you are not leaving
any commits or useful work behind.
Also, this has the same strbuf reset/release leak as the last patch. :)
-Peff
next prev parent reply other threads:[~2012-01-30 21:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 6:09 Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-29 6:56 ` Junio C Hamano
2012-01-29 7:50 ` Junio C Hamano
2012-01-30 6:38 ` Michael Haggerty
2012-01-30 18:48 ` Junio C Hamano
2012-01-30 20:10 ` Junio C Hamano
2012-01-30 21:50 ` Jeff King [this message]
2012-02-06 2:06 ` Junio C Hamano
2012-02-06 2:08 ` Junio C Hamano
2012-02-06 4:30 ` Jeff King
2012-02-06 4:42 ` Andrew Ardill
2012-02-06 5:06 ` Jeff King
2012-02-06 8:51 ` Michael Haggerty
2012-02-06 8:57 ` Jeff King
2012-02-06 18:17 ` Junio C Hamano
2012-02-06 20:14 ` Jeff King
2012-02-07 8:04 ` Michael Haggerty
2012-02-06 18:39 ` demerphq
2012-02-06 5:15 ` Junio C Hamano
2012-02-06 5:18 ` Jeff King
2012-02-06 5:30 ` Junio C Hamano
2012-02-06 5:34 ` Junio C Hamano
2012-02-06 5:45 ` Jeff King
2012-02-06 8:59 ` Michael Haggerty
2012-02-06 18:31 ` Junio C Hamano
2012-01-30 21:48 ` Jeff King
2012-02-06 1:26 ` [PATCH] branch --edit-description: protect against mistyped branch name Junio C Hamano
2012-02-06 1:27 ` Junio C Hamano
2012-02-06 4:20 ` Jeff King
2012-01-31 8:57 ` Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-31 10:01 ` Johannes Sixt
2012-01-31 10:11 ` demerphq
2012-01-31 10:09 ` Jakub Narebski
2012-01-31 16:32 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130215043.GB16149@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).