From: Jeff King <peff@peff.net>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org
Subject: [PATCH 0/5] mixed bag of minor "git mv" fixes
Date: Mon, 12 Dec 2011 02:45:03 -0500 [thread overview]
Message-ID: <20111212074503.GB16511@sigill.intra.peff.net> (raw)
In-Reply-To: <877h226bxe.fsf@picasso.cante.net>
On Sun, Dec 11, 2011 at 11:22:37PM +0200, Jari Aalto wrote:
> Every time I do:
>
> git mv -f FROM TO
>
> Git displays:
>
> warning: destination exists; will overwrite!
>
> Please don't display anything other than errors (no write permission....).
>
> The "-f" is like with mv(1), cp(1); there is nothing than can be done
> afterwards, so the message is redundant and obstructing.
I'm inclined to agree. Outputting a warning just because we did what the
user asked us to is unnecessarily chatty.
When I looked into it, though, it seems that "git mv" is somewhat
neglected, and this trival one-line patch turned into a 5-patch series
of fixes.
[1/5]: docs: mention "-k" for both forms of "git mv"
[2/5]: mv: honor --verbose flag
[3/5]: mv: make non-directory destination error more clear
[4/5]: mv: improve overwrite warning
[5/5]: mv: be quiet about overwriting
-Peff
next prev parent reply other threads:[~2011-12-12 7:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 21:22 git 1.7.7.3: BUG - please make git mv -f quiet Jari Aalto
2011-12-12 7:45 ` Jeff King [this message]
2011-12-12 7:50 ` [PATCH 1/5] docs: mention "-k" for both forms of "git mv" Jeff King
2011-12-12 19:52 ` Junio C Hamano
2011-12-12 7:51 ` [PATCH 2/5] mv: honor --verbose flag Jeff King
2011-12-12 19:53 ` Junio C Hamano
2011-12-12 21:45 ` Jeff King
2011-12-12 7:51 ` [PATCH 3/5] mv: make non-directory destination error more clear Jeff King
2011-12-12 19:55 ` Junio C Hamano
2011-12-12 7:52 ` [PATCH 4/5] mv: improve overwrite warning Jeff King
2011-12-12 19:57 ` Junio C Hamano
2011-12-12 21:52 ` Jeff King
2011-12-12 21:54 ` [PATCHv2 " Jeff King
2011-12-12 21:54 ` [PATCHv2 5/5] mv: be quiet about overwriting Jeff King
2011-12-12 7:54 ` [PATCH " Jeff King
2011-12-12 19:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212074503.GB16511@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).