git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: git@vger.kernel.org, John Kacur <jkacur@gmail.com>
Subject: Re: git fetch overwriting local tags
Date: Wed, 23 Nov 2011 17:16:58 -0500	[thread overview]
Message-ID: <20111123221658.GA22313@sigill.intra.peff.net> (raw)
In-Reply-To: <20111123090821.GL19986@pengutronix.de>

On Wed, Nov 23, 2011 at 10:08:21AM +0100, Uwe Kleine-König wrote:

> John and I wondered about git fetch overwriting local tags. I was sure
> enough to claim that git fetch won't overwrite local tags with remote
> tags having the same name. But after John pointed me to
> 
> 	http://www.pythian.com/news/9067/on-the-perils-of-importing-remote-tags-in-git/
> 
> I tested that (using Debian's 1.7.7.3) and really, git does overwrite
> local tags.
> 
> Here is my test script:
> [...]
> 	git fetch --tags ../a
> [...]
> Is this intended?

Sort of.

By default, "git fetch" will "auto-follow" tags; if you fetch a commit
which is pointed to by a tag, then git will fetch that tag, too. So
generally, you shouldn't need to specify "--tags" at all, because you
will already be getting the relevant tags.

The "--tags" option, however, is a short-hand for saying "fetch all of
the tags", and is equivalent to providing the refspec:

  git fetch ../a refs/tags/*:refs/tags/*

Which of course will update your local tags with similarly-named ones
from the remote.  So in that sense, there is no bug, and it is working
as intended; the problem is that the author's intent was not the same as
your intent. :)

I'm not sure why you're using "--tags" in the first place. That might
help us figure out if there's another way to do what you want that is
safer.

That being said, it would be nice if "--tags" wasn't so surprising.
Three things that I think could help are:

  1. We usually require a "+" on the refspec (or "--force") to update
     non-fast-forward branches. But there is no such safety on tags
     (which generally shouldn't be updated at all). Should we at least
     be enforcing the same fast-forward rules on tag fetches (or even
     something more strict, like forbidding tag update at all unless
     forced)?

  2. We don't keep a reflog on tags. Generally there's no point. But
     it wouldn't be very expensive (since they don't usually change),
     and could provide a safety mechanism here.

  3. Keeping tags from remotes in separate namespaces, but collating
     them at lookup time. This has been discussed, and I think is
     generally a fine idea, but nobody has moved forward with code.

-Peff

  reply	other threads:[~2011-11-23 22:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  9:08 git fetch overwriting local tags Uwe Kleine-König
2011-11-23 22:16 ` Jeff King [this message]
2011-11-24  7:07   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123221658.GA22313@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jkacur@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).