From: Jeff King <peff@peff.net>
To: Daniel Stenberg <daniel@haxx.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 02/14] http: turn off curl signals
Date: Fri, 11 Nov 2011 15:54:42 -0500 [thread overview]
Message-ID: <20111111205442.GC20515@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1111100941380.27581@tvnag.unkk.fr>
On Thu, Nov 10, 2011 at 09:43:40AM +0100, Daniel Stenberg wrote:
> >I'm a little iffy on this one. If I understand correctly, depending
> >on the build and configuration, curl may not be able to timeout
> >during DNS lookups. But I'm not sure if it does, anyway, since we
> >don't set any timeouts.
>
> Right, without a timeout set libcurl won't try to timeout name resolves.
>
> To clarify: when libcurl is built to use the standard synchronous
> name resolver functions it can only abort them after a specified time
> by using signals (on posix systems).
OK, that matches with my understanding. I think this patch is a fine
thing to do for us, then. If we ever do start caring about timing out on
name lookups, we can rework it.
Thanks.
-Peff
next prev parent reply other threads:[~2011-11-11 20:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 7:43 [PATCH 0/14] resumable network bundles Jeff King
2011-11-10 7:45 ` Jeff King
2011-11-10 7:46 ` [PATCH 01/14] t/lib-httpd: check for NO_CURL Jeff King
2011-11-10 7:48 ` [PATCH 02/14] http: turn off curl signals Jeff King
2011-11-10 8:43 ` Daniel Stenberg
2011-11-11 20:54 ` Jeff King [this message]
2011-11-10 7:48 ` [PATCH 03/14] http: refactor http_request function Jeff King
2011-11-10 7:49 ` [PATCH 04/14] http: add a public function for arbitrary-callback request Jeff King
2011-11-10 7:49 ` [PATCH 05/14] remote-curl: use http callback for requesting refs Jeff King
2011-11-10 7:49 ` [PATCH 06/14] transport: factor out bundle to ref list conversion Jeff King
2011-11-10 7:50 ` [PATCH 07/14] bundle: add is_bundle_buf helper Jeff King
2011-11-10 7:50 ` [PATCH 08/14] remote-curl: free "discovery" object Jeff King
2011-11-10 7:50 ` [PATCH 09/14] remote-curl: auto-detect bundles when fetching refs Jeff King
2011-11-10 7:51 ` [PATCH 10/14] remote-curl: try base $URL after $URL/info/refs Jeff King
2011-11-10 7:53 ` [PATCH 11/14] progress: allow pure-throughput progress meters Jeff King
2011-11-10 7:53 ` [PATCH 12/14] remote-curl: show progress for bundle downloads Jeff King
2011-11-10 7:53 ` [PATCH 13/14] remote-curl: resume interrupted bundle transfers Jeff King
2011-11-10 7:56 ` [PATCH 14/14] clone: give advice on how to resume a failed clone Jeff King
2011-11-10 21:21 ` Junio C Hamano
2011-11-11 20:52 ` Jeff King
2011-11-11 13:13 ` [PATCH 0/14] resumable network bundles David Michael Barr
2011-11-12 16:11 ` Tay Ray Chuan
2011-11-12 17:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111205442.GC20515@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).