From: Jeff King <peff@peff.net>
To: Michael Schubert <mschub@elegosoft.com>
Cc: git@vger.kernel.org, Alex Vandiver <alex@chmrr.net>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: Doesn't disambiguate between 'external command failed' and 'command not found'
Date: Wed, 6 Jul 2011 14:00:26 -0400 [thread overview]
Message-ID: <20110706180026.GC17978@sigill.intra.peff.net> (raw)
In-Reply-To: <20110706175803.GB17978@sigill.intra.peff.net>
On Wed, Jul 06, 2011 at 01:58:03PM -0400, Jeff King wrote:
> > Like this? I've replaced "Check the #!-line of the git-%s script." with
> > "Maybe git-%s is broken?" to be less technical and specific..
>
> Yeah, looks good to me (unless somebody wants to do something more
> elaborate to catch other exec problems, but I personally don't think
> it's worth the effort).
One minor nit, though. I haven't been paying attention to the progress
of the gettext topics, but should this message:
> +static const char bad_interpreter_advice[] =
> + "'%s' appears to be a git command, but we were not\n"
> + "able to execute it. Maybe git-%s is broken?";
Actually be inside _() for gettext?
-Peff
next prev parent reply other threads:[~2011-07-06 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 16:49 Doesn't disambiguate between 'external command failed' and 'command not found' Alex Vandiver
2011-07-05 20:41 ` Michael Schubert
2011-07-05 23:16 ` Jeff King
2011-07-05 23:22 ` Jeff King
2011-07-06 11:24 ` Sverre Rabbelier
2011-07-06 11:47 ` Michael Schubert
2011-07-06 17:58 ` Jeff King
2011-07-06 18:00 ` Jeff King [this message]
2011-07-06 23:25 ` Junio C Hamano
2011-07-08 10:08 ` Michael Schubert
2011-07-08 16:52 ` Junio C Hamano
2011-07-06 17:24 ` Junio C Hamano
2011-07-06 17:56 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706180026.GC17978@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
--cc=mschub@elegosoft.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).