git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Claire Fousse <claire.fousse@ensimag.imag.fr>
Cc: git@vger.kernel.org, Sylvain Boulme <Sylvain.Boulme@imag.fr>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: Git-Mediawiki : cloning a set of pages
Date: Thu, 9 Jun 2011 11:50:01 -0400	[thread overview]
Message-ID: <20110609155001.GA14969@sigill.intra.peff.net> (raw)
In-Reply-To: <20110608151940.GD7805@sigill.intra.peff.net>

On Wed, Jun 08, 2011 at 11:19:40AM -0400, Jeff King wrote:

> Maybe it would be even simpler and more flexible to give clone a "-c"
> flag that writes specific config variables in the newly-created
> repository. Like:
> 
>   git clone -c mediawiki.page=page1 \
>             -c mediawiki.page=page2 \
>             http://...
> 
> Then the remote helper can just consult the git config. As a bonus, it
> also lets you do things like:
> 
>   git clone -c core.ignorecase=true git://...
> 
> which is currently awkward (you either have to have set such variable in
> your ~/.gitconfig, or you must use init+config+fetch to do a clone
> manually.

This turned out to be a very tiny amount of code, but I found a ton
of other bugs while working on it. :)

So the patch series is long, but the important bits are at the end. I
factored the code from the existing "git -c", so most of the bugfixes
are there.

  [01/10]: strbuf_split: add a max parameter
  [02/10]: fix "git -c" parsing of values with equals signs

These two are the first bugfix.

  [03/10]: config: die on error in command-line config

Another bugfix.

  [04/10]: config: avoid segfault when parsing command-line config

Another bugfix.

  [05/10]: strbuf: allow strbuf_split to work on non-strbufs
  [06/10]: config: use strbuf_split_str instead of a temporary strbuf

Plugging a memory leak.

  [07/10]: parse-options: add OPT_STRING_LIST helper
  [08/10]: remote: use new OPT_STRING_LIST
  [09/10]: config: make git_config_parse_parameter a public function

These are refactoring for 10/10.

  [10/10]: clone: accept config options on the command line

And this is the actual patch.

-Peff

  parent reply	other threads:[~2011-06-09 15:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 11:19 Git-Mediawiki : cloning a set of pages Claire Fousse
2011-06-08 15:19 ` Jeff King
2011-06-08 17:04   ` Sverre Rabbelier
2011-06-08 17:13     ` Jeff King
2011-06-09 15:50   ` Jeff King [this message]
2011-06-09 15:51     ` [PATCH 01/10] strbuf_split: add a max parameter Jeff King
2011-06-13 17:30       ` Junio C Hamano
2011-06-13 19:20         ` Jeff King
2011-06-09 15:51     ` [PATCH 02/10] fix "git -c" parsing of values with equals signs Jeff King
2011-06-09 15:52     ` [PATCH 03/10] config: die on error in command-line config Jeff King
2011-06-09 15:52     ` [PATCH 04/10] config: avoid segfault when parsing " Jeff King
2011-06-13 17:30       ` Junio C Hamano
2011-06-13 19:22         ` Jeff King
2011-06-09 15:54     ` [PATCH 05/10] strbuf: allow strbuf_split to work on non-strbufs Jeff King
2011-06-09 15:55     ` [PATCH 06/10] config: use strbuf_split_str instead of a temporary strbuf Jeff King
2011-06-09 15:55     ` [PATCH 07/10] parse-options: add OPT_STRING_LIST helper Jeff King
2011-06-09 15:55     ` [PATCH 08/10] remote: use new OPT_STRING_LIST Jeff King
2011-06-09 15:56     ` [PATCH 09/10] config: make git_config_parse_parameter a public function Jeff King
2011-06-09 15:57     ` [PATCH 10/10] clone: accept config options on the command line Jeff King
2011-06-09 17:10       ` Bert Wesarg
2011-06-09 17:12         ` Jeff King
2011-06-09 20:56           ` Jeff King
2011-06-09 22:34       ` Matthieu Moy
2011-06-08 17:14 ` Git-Mediawiki : cloning a set of pages Jakub Narebski
2011-06-09  9:06   ` Claire Fousse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110609155001.GA14969@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=Sylvain.Boulme@imag.fr \
    --cc=claire.fousse@ensimag.imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).