From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: John 'Warthog9' Hawley <warthog9@eaglescrag.net>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH/RFC 10/11] gitweb.js: Add UI for selecting common timezone to display dates
Date: Sun, 10 Apr 2011 16:39:03 +0200 [thread overview]
Message-ID: <201104101639.04466.jnareb@gmail.com> (raw)
In-Reply-To: <201104101136.58325.jnareb@gmail.com>
Jakub Narebski wrote:
> Jakub Narebski wrote:
>
> > KNOWN BUGS:
> > ===========
> > * In 'log' view menu is generated on the right side of whole page,
> > instead of at near date, as is the case with 'summary', 'commit',
> > 'commitdiff', and 'tag' views.
>
> I'm not sure if it is behavior expected by CSS visual formatting model
> or not: the issue is with absolutely positioned block element
>
> div.popup { position: absolute; top: 0; right: 0; }
>
> inside relatively positioned _inline_ element
>
> span.marker { position: relative; }
>
> In this case 'top: 0; right: 0' refers somehow to parent block element
> of inline element... at least that's what I think. Note that also in
> the case of 'summary', 'commit', 'commitdiff' and 'tag' views the popup
> position is not entirely what one could expect...
>
> What is strange is that 'top: 0; left: 0' works correctly (sic!).
This looks like a bug in Mozilla 1.7.12 (Gecko/20050923) I ordinarily use.
Checking simplified test case with Konqueror 3.5.3 shows correct behavior
for all combinations of absolute positioning, at least when
span.marker { position: relative; display: inline-block; }
Without "display: inline-block;" the "top: 0; right: 0;" is displaced
compared to the end of marker.
Because vger anti-spam filter doesn't like HTML attachments, you can check
test case here: https://gist.github.com/912389
Try it also with 'display: inline-block;' uncommented.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-04-10 14:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 22:49 [PATCH 00/11] gitweb: Change timezone Jakub Narebski
2011-04-09 22:49 ` [PATCH 01/11] gitweb: Split JavaScript for maintability, combining on build Jakub Narebski
2011-04-09 22:49 ` [PATCH 02/11] gitweb.js: Update and improve comments in JavaScript files Jakub Narebski
2011-04-09 22:49 ` [PATCH/RFC 03/11] gitweb.js: Provide default values for padding in padLeftStr and padLeft Jakub Narebski
2011-04-09 22:49 ` [PATCH 04/11] gitweb.js: Extract and improve datetime handling Jakub Narebski
2011-04-09 22:49 ` [PATCH 05/11] gitweb.js: Introduce gitweb/static/js/lib/cookies.js Jakub Narebski
2011-04-09 22:49 ` [PATCH 06/11] gitweb.js: Provide getElementsByClassName method (if it not exists) Jakub Narebski
2011-04-09 22:49 ` [PATCH 07/11] gitweb: Refactor generating of long dates into format_timestamp_html Jakub Narebski
2011-04-09 22:49 ` [RFC/PATCH 08/11] gitweb: Unify the way long timestamp is displayed Jakub Narebski
2011-04-09 22:49 ` [PATCH 09/11] gitweb: JavaScript ability to adjust time based on timezone Jakub Narebski
2011-04-09 22:49 ` [PATCH/RFC 10/11] gitweb.js: Add UI for selecting common timezone to display dates Jakub Narebski
2011-04-10 9:36 ` Jakub Narebski
2011-04-10 14:39 ` Jakub Narebski [this message]
2011-04-10 15:10 ` Jakub Narebski
2011-04-09 22:49 ` [PATCH/RFC 11/11] gitweb: Make JavaScript ability to adjust timezones configurable Jakub Narebski
2011-04-12 1:19 ` [PATCH 00/11] gitweb: Change timezone Kevin Cernekee
2011-04-12 12:44 ` Jakub Narebski
2011-04-12 13:24 ` [PATCHv2 10/11] gitweb.js: Add UI for selecting common timezone to display dates Jakub Narebski
2011-04-12 13:25 ` [PATCHv2 11/11] gitweb: Make JavaScript ability to adjust timezones configurable Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104101639.04466.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=cernekee@gmail.com \
--cc=git@vger.kernel.org \
--cc=warthog9@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).