From: Jeff King <peff@peff.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] fetch-pack: Finish negotation if remote replies "ACK %s ready"
Date: Thu, 17 Mar 2011 03:16:01 -0400 [thread overview]
Message-ID: <20110317071600.GG11931@sigill.intra.peff.net> (raw)
In-Reply-To: <20110317071512.GF11931@sigill.intra.peff.net>
On Thu, Mar 17, 2011 at 03:15:12AM -0400, Jeff King wrote:
> > Assuming the client is only following the remote (and does not make
> > its own local commits), the client needs 11 rounds to spin through
> > the entire list of tags (32 commits per round, ceil(339/32) == 11).
> > Unfortunately the server knows on the first "have %s" line that
> > it can produce a good pack, and does not need to see the remaining
> > 320 tags in the other 10 rounds.
>
> Does this optimization help in that case? From looking at the code, it
> seems that we offer "ACK %s ready" only in the case that the client
> has something we do not. I.e., they _are_ building local commits on top.
OK, never mind, I just read your 2/2. ;)
Sorry for the noise.
-Peff
next prev parent reply other threads:[~2011-03-17 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 23:48 [PATCH 1/2] fetch-pack: Finish negotation if remote replies "ACK %s ready" Shawn O. Pearce
2011-03-14 23:48 ` [PATCH 2/2] upload-pack: More aggressively send 'ACK %s ready' Shawn O. Pearce
2011-03-17 7:15 ` [PATCH 1/2] fetch-pack: Finish negotation if remote replies "ACK %s ready" Jeff King
2011-03-17 7:16 ` Jeff King [this message]
2011-03-17 15:51 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317071600.GG11931@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).