From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
"Dmitry S. Kravtsov" <idkravitz@gmail.com>,
Shawn Pearce <spearce@spearce.org>
Subject: Re: [PATCH] cache-tree: do not cache empty trees
Date: Mon, 7 Feb 2011 14:18:55 +0200 [thread overview]
Message-ID: <20110207121855.GA7298@LK-Perkele-VI.localdomain> (raw)
In-Reply-To: <20110207095713.GA19653@do>
On Mon, Feb 07, 2011 at 04:57:13PM +0700, Nguyen Thai Ngoc Duy wrote:
>
> Perhaps it's not a good approach after all. What I wanted was to make
> pre-1.8.0 tolerate empty trees created by 1.8.0. Perhaps it's better
> to just let pre-1.8.0 refuse to work with empty trees, forcing users
> to upgrade to 1.8.0?
>
> The (untested) patch below would make git refuse to create an index
> from a tree that contains empty trees. Hmm?
Remember, many distros ship with old versions of Git. Debian stable
is now at 1.7.2.3 (Squeeze became Debian 6.0) and it'll take years
before next release. What about these?
Making previous versions refuse to work with empty trees isn't exactly
trivial, as the tree parser seems to be written to be extremely
liberal on what it accepts.
-Ilari
next prev parent reply other threads:[~2011-02-07 12:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 8:30 [PATCH] cache-tree: do not cache empty trees Nguyễn Thái Ngọc Duy
2011-02-05 9:50 ` Nguyễn Thái Ngọc Duy
2011-02-05 10:14 ` Jonathan Nieder
2011-02-05 10:32 ` Nguyen Thai Ngoc Duy
2011-02-05 14:07 ` Nguyễn Thái Ngọc Duy
2011-02-07 2:09 ` Junio C Hamano
2011-02-07 2:36 ` Nguyen Thai Ngoc Duy
2011-02-07 8:17 ` [PATCH] correct type of EMPTY_TREE_SHA1_BIN Jonathan Nieder
2011-02-09 23:33 ` Junio C Hamano
2011-02-07 9:17 ` [PATCH] cache-tree: do not cache empty trees Jonathan Nieder
2011-02-07 9:57 ` Nguyen Thai Ngoc Duy
2011-02-07 12:18 ` Ilari Liusvaara [this message]
2011-02-07 12:29 ` Nguyen Thai Ngoc Duy
2011-02-07 12:32 ` Jonathan Nieder
2011-02-07 20:48 ` Junio C Hamano
2011-02-08 4:11 ` Nguyen Thai Ngoc Duy
2011-02-08 4:30 ` Jonathan Nieder
2011-02-15 10:19 ` Yann Dirson
2011-02-16 14:29 ` Jakub Narebski
2011-02-08 10:40 ` Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207121855.GA7298@LK-Perkele-VI.localdomain \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=idkravitz@gmail.com \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).