From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: sanitize more git environment variables
Date: Wed, 26 Jan 2011 15:34:44 -0500 [thread overview]
Message-ID: <20110126203444.GB27478@sigill.intra.peff.net> (raw)
In-Reply-To: <20110126203331.GA27478@sigill.intra.peff.net>
On Wed, Jan 26, 2011 at 03:33:32PM -0500, Jeff King wrote:
> These variables should generally not be set in one's
> environment, but they do get set by rebase, which means
> doing an interactive rebase like:
>
> pick abcd1234 foo
> exec make test
>
> will cause false negatives in the test suite.
Or I guess false positives, depending on your definition of positive and
negative. I.e., tests will fail when they shouldn't. :)
-Peff
next prev parent reply other threads:[~2011-01-26 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 20:33 [PATCH] tests: sanitize more git environment variables Jeff King
2011-01-26 20:34 ` Jeff King [this message]
2011-01-26 20:43 ` Junio C Hamano
2011-01-27 0:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126203444.GB27478@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).