From: Johannes Sixt <j6t@kdbg.org>
To: Sascha Peilicke <saschpe@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] No color diff when redirecting to file
Date: Sun, 23 Jan 2011 15:47:17 +0100 [thread overview]
Message-ID: <201101231547.18529.j6t@kdbg.org> (raw)
In-Reply-To: <201101231410.48528.saschpe@gmx.de>
The subject line reads as if you want that color markup appears in a file.
On Sonntag, 23. Januar 2011, Sascha Peilicke wrote:
> Previously, when having color diffs enabled and redirecting 'git diff'
> into a file, one ends up with a messed up file containing termcap color
> stuff. This change disables color when diff output is redirected into a
> file.
But this description and the patch read as if you don't want it.
That said, I cannot reproduce. Perhaps your configuration says
color.ui=always? If so, then this is expected behavior and not a bug, IMO.
-- Hannes
next prev parent reply other threads:[~2011-01-23 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 13:10 [PATCH] No color diff when redirecting to file Sascha Peilicke
2011-01-23 14:47 ` Johannes Sixt [this message]
2011-01-23 17:29 ` Matthieu Moy
2011-01-23 23:32 ` Junio C Hamano
2011-01-24 8:59 ` Sascha Peilicke
2011-01-24 9:38 ` Matthieu Moy
2011-01-24 8:56 ` Sascha Peilicke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101231547.18529.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=saschpe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).