From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Thomas Rast <trast@student.ethz.ch>,
Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org, Kevin Ballard <kevin@sb.org>,
Yann Dirson <dirson@bertin.fr>, Eric Raible <raible@nextest.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] Documentation: suggest "reset --keep" to undo a commit
Date: Fri, 21 Jan 2011 13:14:59 -0600 [thread overview]
Message-ID: <20110121191459.GC16325@burratino> (raw)
In-Reply-To: <7voc7ap3dp.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> But the user could do the reviewing and thinking with some local changes
> still in the working tree (they are incredients for the fourth commit yet
> to be made) and decide to branch at that point. The description in <1>
> needs to be updated to hint that there can be uncommitted changes, e.g.
>
> You have worked for some time, made a few commits, and may have
> uncommitted changes. After reviewing the current state, you
> realized that ...
>
> Using --keep may help the user do so, but only if the local changes do not
> conflict with the changes in the recent commits to be discarded, right?
I think this explanation misses out on something.
I may be abusing git in a certain way, but I find myself in the
following situation fairly often:
... hack hack hack ...
git add -p; # hmm, looks like multiple features.
git stash -k
... test ...
git commit; # commit feature #1
git stash pop
git add -p
git stash -k
... test ...
git commit; # commit feature #2
git stash pop
# hmm, feature #2 is not suitable for this branch.
git branch wip/feature-2
git reset --keep HEAD^; # <*>
git add -p
git stash -k
... test ...
git commit; # commit feature #3
On line <*>, I am just not thinking about the uncommitted changes.
They may be there or they may not. If they are in the way of what I
am trying to do, "git reset --keep" will politely inform me so I can
act accordingly (usually stash, commit, or discard them).
> By the way, a more natural way to do this would actually be:
>
> $ git checkout -b topic/wip
> $ git branch -f @{-1} HEAD~3
True. (I think the intended scenario was
git branch topic/wip; # save the tip for later
git reset --keep HEAD~3
# now what was I working on?
... hack hack hack ...
# okay, now we have time for that diversion.
git checkout topic/wip
but it would be nice to contrast it with the one you described.)
> or using the stash:
>
> $ git stash ;# save local changes
> $ git branch topic/wip ;# and mark the tip before rewinding
> $ git reset --hard HEAD~3 ;# you could say --keep here too
> $ git checkout topic/wip ;# and then continue
> $ git stash pop ;# with the local changes
This approach leaves more files touched and more targets to be rebuilt
by "make".
> Please tell a story where keep makes more sense than hard by enhancing the
> explanatory text <1> associated with this section. The current text says
> that the three topmost commit representing what you have recently worked
> so far are all unwanted, strongly hinting that hard is more appropriate
> thing to do than keep, which is not what we want if we are changing the
> example to use keep.
Maybe the best story would be "you have just explored a blind alley
and decided the last three commits are not a good idea at all", with
reference to a new section explaining that
* --soft is for when the commit in preparation has the right content
but should be on top of a different parent (e.g., squashing commits)
* --keep is for transporting your local changes to a different commit
(e.g., rewinding a branch or transplanting changes)
- --merge is a limited and low-level tool for recovering from a
conflicted merge and most often will take ORIG_HEAD as its argument.
Maybe in the future merges will save more information so reset --merge
can error out more often.
- --hard is for resetting to a known state
- --mixed is for resetting to a known state but leaving the worktree
alone
> It would be sufficient to just hint that the uncommitted changes that you
> have in your working tree are unrelated to what these three commits wanted
> to do (e.g. you always keep small changes around, such as debugging
> printf's
That use case is less interesting to me --- it is relatively harmless
to clobber such content.
next prev parent reply other threads:[~2011-01-21 19:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 13:08 Black smoke from git rebase -i exec Ævar Arnfjörð Bjarmason
2010-08-10 13:37 ` Matthieu Moy
2010-08-10 13:57 ` Ævar Arnfjörð Bjarmason
2010-08-10 14:12 ` Johannes Sixt
2010-08-10 14:16 ` Ævar Arnfjörð Bjarmason
2010-08-10 15:05 ` Matthieu Moy
2010-08-10 15:17 ` [PATCH 1/2 (fix broken test)] rebase -i: add exec command to launch a shell command Matthieu Moy
2010-08-11 18:31 ` Junio C Hamano
2010-08-12 7:47 ` Matthieu Moy
2011-01-16 1:59 ` [PATCH 0/2] rebase -i: in-editor documentation nits Jonathan Nieder
2011-01-16 2:01 ` [PATCH 1/2] rebase -i: reword in-editor documentation of "exec" Jonathan Nieder
2011-01-16 10:27 ` Matthieu Moy
2011-01-18 15:05 ` Junio C Hamano
2011-01-20 20:09 ` Jonathan Nieder
2011-01-20 20:59 ` Junio C Hamano
2011-01-21 0:36 ` [PATCH 1/2 v2] rebase -i: clarify " Jonathan Nieder
2011-01-21 6:59 ` Matthieu Moy
2011-01-21 7:47 ` Jonathan Nieder
2011-01-21 10:43 ` Matthieu Moy
2011-01-16 2:02 ` [PATCH 2/2] rebase -i: explain how to discard all commits Jonathan Nieder
2011-01-20 19:39 ` [PATCH 2/2] " Nicolas Sebrecht
2011-01-20 19:57 ` Jonathan Nieder
2011-01-20 20:08 ` Nicolas Sebrecht
2011-01-20 20:34 ` Thomas Rast
2011-01-20 21:28 ` Junio C Hamano
2011-01-21 7:04 ` Johannes Schindelin
2011-01-21 7:37 ` [PATCH] Documentation: suggest "reset --keep" to undo a commit Jonathan Nieder
2011-01-21 17:34 ` Junio C Hamano
2011-01-21 19:14 ` Jonathan Nieder [this message]
2011-01-21 20:28 ` Junio C Hamano
2011-01-21 16:51 ` [PATCH 2/2] Re: rebase -i: explain how to discard all commits Junio C Hamano
2011-01-21 17:05 ` Matthieu Moy
2011-01-21 17:57 ` Joshua Jensen
2011-01-21 18:37 ` [PATCH] Documentation: do not treat reset --keep as a special case Jonathan Nieder
2011-01-21 20:35 ` Junio C Hamano
2011-01-26 7:33 ` [PATCH 2/2] Re: rebase -i: explain how to discard all commits Jay Soffian
2011-01-23 20:10 ` Johannes Schindelin
2010-08-10 15:17 ` [PATCH 2/2] test-lib: user-friendly alternatives to test [-d|-f|-e] Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121191459.GC16325@burratino \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=chriscool@tuxfamily.org \
--cc=dirson@bertin.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
--cc=nicolas.s.dev@gmx.fr \
--cc=raible@nextest.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).