From: Jonathan Nieder <jrnieder@gmail.com>
To: Sam Vilain <sam@vilain.net>
Cc: Tomas Carnecky <tom@dbservice.com>,
git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
David Barr <david.barr@cordelta.com>,
Stephen Bash <bash@genarts.com>
Subject: fast-import --report-fd (Re: fast-import tweaks for remote helpers)
Date: Wed, 5 Jan 2011 15:20:18 -0600 [thread overview]
Message-ID: <20110105212018.GA22975@burratino> (raw)
In-Reply-To: <20101212171633.GB18847@burratino>
Jonathan Nieder wrote:
> Sam Vilain wrote:
>> What happened to --report-fd ?
>
> The patch still works. The main problem with report-fd is that it
> introduced a synchronization point after every commit: the frontend
> has to read the commit id before fast-import will continue.
Correction: more precisely, that was and is the main problem with
svn-fe's use of bidirectional communication. An application like
Tom's remote helper would probably not suffer so much from it, since
commit ids are just queued up as long as the pipe doesn't fill before
the frontend reads any. It is transactions like
FI> r5 = 734987a9878b97c879c798a897c897ac
FE> cat 734987a9878b97c879c798a897c897ac
FI> 734987a9878b97c879c798a897c897ac commit 448
tree 8d5bcf0f24bdfea1fdab8d39ba3c8ba91a52547c
parent 84279592b8b5816d00300ba5d4412adf05cc80d6
parent 3ca7353cab4ed6c7efac0c8d7477c87112fc7350
author Junio C Hamano <gitster@pobox.com> 1294187068 -0800
committer Junio C Hamano <gitster@pobox.com> 1294187068 -0800
Merge branch 'sr/gitweb-hilite-more' into pu
* sr/gitweb-hilite-more:
gitweb: remove unnecessary test when closing file descriptor
gitweb: add extensions to highlight feature map
FE> cat 8d5bcf0f24bdfea1fdab8d39ba3c8ba91a52547c "main.c"
(i.e., round-trips) that were and are creating overhead in svn-fe.
See [1] if curious about details.
So please don't be dissuaded by the nonsense I sent. :)
[1] http://colabti.org/irclogger/irclogger_log_search/git-devel?search=overhead&action=search
next prev parent reply other threads:[~2011-01-05 21:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 11:21 Status of the svn remote helper project (Nov, 2010) Jonathan Nieder
2010-11-07 12:06 ` David Michael Barr
2010-11-08 3:56 ` David Barr
2010-11-08 6:11 ` Jonathan Nieder
2010-11-08 6:20 ` David Barr
2010-11-07 12:50 ` Ramkumar Ramachandra
2010-11-07 17:42 ` Jonathan Nieder
2010-11-21 6:31 ` Status of the svn remote helper project (Nov 2010, #2) Jonathan Nieder
2010-11-21 9:38 ` David Michael Barr
2010-11-21 23:06 ` Jonathan Nieder
2010-11-22 2:06 ` David Barr
2010-12-05 11:37 ` Status of the svn remote helper project (Dec 2010, #1) Jonathan Nieder
2010-12-08 18:26 ` Tomas Carnecky
2010-12-12 6:14 ` fast-import tweaks for remote helpers (Re: Status of the svn remote helper project (Dec 2010, #1)) Jonathan Nieder
2010-12-12 9:53 ` Sam Vilain
2010-12-12 17:16 ` fast-import tweaks for remote helpers Jonathan Nieder
2011-01-05 21:20 ` Jonathan Nieder [this message]
2011-01-05 23:39 ` Status of the svn remote helper project (Jan 2011, #1) Jonathan Nieder
2011-01-07 14:00 ` David Michael Barr
2011-02-11 9:09 ` Plans for the vcs-svn-pu branch Jonathan Nieder
2011-02-11 10:36 ` [PATCH] svn-fe: warn about experimental status Jonathan Nieder
2011-02-11 15:49 ` Plans for the vcs-svn-pu branch Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105212018.GA22975@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=bash@genarts.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=sam@vilain.net \
--cc=srabbelier@gmail.com \
--cc=tom@dbservice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).