git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org
Subject: Re: [GITK PATCH] gitk: add menuitem for file checkout from selected or parent commit
Date: Sun, 12 Dec 2010 10:23:24 +1100	[thread overview]
Message-ID: <20101211232324.GB3788@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <20100928200344.GA12843@book.hvoigt.net>

On Tue, Sep 28, 2010 at 10:03:45PM +0200, Heiko Voigt wrote:

> This is useful if a user wants to checkout a file from a certain
> commit. This is equivalent to
> 
>   git checkout $commit $file
> 
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>

Thanks for the patch.  However, the commit message doesn't mention
that the patch also adds the 'checkout from parent' menu item or why
that's a useful thing to have.  I like the 'checkout from this commit'
thing but I don't immediately see why checking out from the first
parent is so useful that we have to have it as a menu item, but
checking out from other parents of a merge isn't.

Also, don't bother updating the po files.  The translators generally
prefer it if we don't.

Paul.

  parent reply	other threads:[~2010-12-11 23:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 20:03 [GITK PATCH] gitk: add menuitem for file checkout from selected or parent commit Heiko Voigt
2010-09-28 21:09 ` Ævar Arnfjörð Bjarmason
2010-09-29 15:23   ` Heiko Voigt
2010-09-29 15:48     ` Ævar Arnfjörð Bjarmason
2010-09-30 18:29       ` [PATCH v2] gitk: add menuitem for file checkout from this " Heiko Voigt
2010-09-29 15:27 ` [GITK PATCH] gitk: add menuitem for file checkout from selected " Michele Ballabio
2010-12-11 23:23 ` Paul Mackerras [this message]
2010-12-13 21:46   ` [PATCH v3] gitk: add menuitem for file checkout from this " hvoigt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101211232324.GB3788@brick.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).