From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: [PATCH] use persistent memory for rejected paths
Date: Mon, 15 Nov 2010 20:02:06 +0100 [thread overview]
Message-ID: <20101115190206.GA2992@localhost> (raw)
In-Reply-To: <7vvd3yl9q2.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Mon, Nov 15, 2010 at 10:31:33AM -0800, Junio C Hamano wrote:
>
> Hmmm, all calls to add_rejected_path() seems to be with ce->name as the
> path parameter,
Yes. All of them except for the leading path checks I introduced
recently. In that code path we have to report untracked files which
do not have a corresponding index entry.
> That is true but I wonder if the order should be "whatever the processing
> order happens to be" in the first place, as this is a report to the end
> user, no? Perhaps "collect in strlist, sort at the end before showing" is
> a more desirable thing to do?
Is the order of processing not alphabetic? It is at least in the
tests that I touched.
Clemens
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-11-15 19:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 19:53 What's cooking in git.git (Nov 2010, #01; Tue, 9) Junio C Hamano
2010-11-09 20:11 ` Ævar Arnfjörð Bjarmason
2010-11-09 20:19 ` Matthieu Moy
2010-11-09 20:29 ` Drew Northup
2010-11-09 20:38 ` Jonathan Nieder
2010-11-09 21:38 ` Jakub Narebski
2010-11-11 17:21 ` Junio C Hamano
2010-11-11 23:53 ` Jakub Narebski
2010-11-09 21:46 ` Johan Herland
2010-11-09 22:11 ` Jeff King
2010-11-09 22:17 ` Erik Faye-Lund
2010-11-09 22:21 ` Ævar Arnfjörð Bjarmason
2010-11-09 22:25 ` Erik Faye-Lund
2010-11-09 22:27 ` Ævar Arnfjörð Bjarmason
2010-11-10 20:35 ` Yann Dirson
2010-11-11 12:26 ` Nguyen Thai Ngoc Duy
2010-11-11 14:28 ` Nguyen Thai Ngoc Duy
2010-11-14 13:02 ` [PATCH] use persistent memory for rejected paths Clemens Buchacher
2010-11-15 18:31 ` Junio C Hamano
2010-11-15 19:02 ` Clemens Buchacher [this message]
2010-11-15 19:03 ` Matthieu Moy
2010-11-15 19:41 ` Clemens Buchacher
2010-11-15 19:52 ` [PATCH v2] " Clemens Buchacher
2010-11-16 16:41 ` Matthieu Moy
2010-11-15 23:05 ` [PATCH] " Junio C Hamano
2010-11-15 23:30 ` Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115190206.GA2992@localhost \
--to=drizzd@aon.at \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).