From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Haller <lists@haller-berlin.de>
Cc: Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org, Pat Thoyts <patthoyts@users.sourceforge.net>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] gitk: Add "First parent" checkbox
Date: Mon, 8 Nov 2010 15:11:01 -0600 [thread overview]
Message-ID: <20101108211101.GA13114@burratino> (raw)
In-Reply-To: <1jrnp0m.116vp4ycag4blM%lists@haller-berlin.de>
Stefan Haller wrote:
> Most of the diff related options are
> ones that I want to toggle with one click. That's certainly true for
> "Ignore space change", "First parent", and the "Diff/Old Version/New
> Version" radio buttons. I would hate to see any of them be removed from
> the diff pane.
Thanks, that's useful information. Could you give example workflows
to illustrate this? Here's an example:
Toggling between "Diff/Old version/New version" with a single click
allows one to compare the preimage and postimage of a patch visually.
It makes what changed much more obvious.
Historically these have been radio buttons on the top-left part of
the diff pane. If they move, it might be hard for people already
familiar with gitk to find them.
The preimage/postimage toggle is a useful and novel feature, and it
is greedy with respect to screen real estate (a few extra diff
lines can go a long way), so it would not be good to hide it in a
separate "more diff options" toolbar.
The case for one-click "diff against parent" is less clear. Is it
that it gets toggled in practice often (i.e., avoiding pointless
repetitive actions)?
Hope that helps.
next prev parent reply other threads:[~2010-11-08 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 10:42 [PATCH] gitk: Add "First parent" checkbox Stefan Haller
2010-11-08 17:24 ` Jonathan Nieder
2010-11-08 19:40 ` Stefan Haller
2010-11-08 19:48 ` Jonathan Nieder
2010-11-08 20:23 ` Stefan Haller
2010-11-08 21:11 ` Jonathan Nieder [this message]
2010-11-10 7:17 ` Stefan Haller
2010-12-12 4:27 ` Paul Mackerras
2010-12-12 20:08 ` [PATCH v2/RFC] " lists
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 11:58 [PATCH] " Stefan Haller
2013-10-30 17:10 Show patch in gitk --first-parent ? Karl Wiberg
2013-10-31 14:59 ` [PATCH] gitk: Add "First parent" checkbox Stefan Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108211101.GA13114@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=lists@haller-berlin.de \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).