From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] Use git_open_noatime when accessing pack data
Date: Wed, 3 Nov 2010 12:41:48 -0500 [thread overview]
Message-ID: <20101103174148.GB13377@burratino> (raw)
In-Reply-To: <7v8w1axrnp.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> (1) introduce "int git_open_ro(const char *)" to replace the current
> git_open_noatime(). The point is that the function no longer is
> about avoiding from smudging the inode metadata. Instead, it becomes
> the preferred way for us to get a read-only fd.
[...]
> We can of course do without s/git_open_noatime/git_open_ro/; and it will
> make the patch much smaller. The rename is purely a clarification of the
> API and is optional. It may make it easier to explain the name of the new
> function, though.
Probably a silly question, but should all readonly open()s actually use
noatime? Some uses for atime:
- tmpwatch. That one's a bit insane, anyway, but I think it might
work because loose objects and packs are read-only.
- mail clients. For this case, noatime is the right thing to do ---
git's access does mean the mail was read.
- listing important files, as in popularity-contest. For this,
noatime is also the right thing to do.
Judging from these three use cases, readonly open()s to the worktree
should indeed use noatime, but open()s of .git/config, say, should
not. Hmm.
next prev parent reply other threads:[~2010-11-03 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 22:54 [PATCH 0/2] Work around too many file descriptors Shawn O. Pearce
2010-11-01 22:54 ` [PATCH 1/2] Use git_open_noatime when accessing pack data Shawn O. Pearce
2010-11-03 17:07 ` Junio C Hamano
2010-11-03 17:41 ` Jonathan Nieder [this message]
2010-11-03 19:35 ` Junio C Hamano
2010-11-04 5:04 ` Jonathan Nieder
2010-11-04 5:23 ` Kevin Ballard
2010-11-05 17:26 ` Junio C Hamano
2010-11-01 22:54 ` [PATCH 2/2] Work around EMFILE when there are too many pack files Shawn O. Pearce
2010-11-02 8:44 ` Johannes Sixt
2010-11-03 17:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103174148.GB13377@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).